GNOME Bugzilla – Bug 414360
linked images preceded by double <br>s cause Orca to get stuck
Last modified: 2007-03-04 15:57:16 UTC
In the test case (to be attached), try to use Up/Down arrow to navigate among the page's contents. You will get stuck at/in the linked image. Notes: 1. If you remove one of the <br>s you will not get stuck. 2. If you provide alternative text for the linked image you will not get stuck. 3. In order to determine if this was a(nother) side effect of the patches for bugs 411261 and 413253, I reversed each of those patches. If you reverse 413253, you won't get stuck at the image, but you won't be able to Up/Down arrow past it. If you then reverse 411261, you will get stuck at the image. 4. If, when you get stuck heading down you press Right arrow once, you will be able to Up/Down arrow to and past the linked image without getting stuck. Investigating further....
Created attachment 83842 [details] aforementioned test case
Created attachment 83846 [details] [review] proposed patch take 1 :-) In the test case, and on the page upon which the test case is based (http://www.aftonbladet.se/vss/noje/story/0,2789,1013670,00.html) we're getting bogus extents -- assuming of course that extents should not be really large negative numbers. This patch checks to be sure that extents are not bogus before proceeding. Seems to solve the problem. But since I'm still learning.... Will, what am I overlooking here?
Created attachment 83848 [details] [review] proposed patch take 2 :-) Will IMed me to tell me what I was overlooking. In particular, "Extents can have negative x and y values if the object is scrolled off the screen." Good to know. Thanks Will! This version just checks to see if the width and/or height are negative. Still seems to solve the problem in the test case and the page linked to in my previous comment.
This looks to be a good fix. Please submit and close this bug as FIXED. Thanks!
Done. Thanks for the help and review!