GNOME Bugzilla – Bug 414199
information sidebar
Last modified: 2007-07-10 01:43:25 UTC
In nautilus 2.17.2 i find small bug, in the panel of the information the part of the information is leveled to the left, but the part for the middle (icon), i think the whole should be center its look the best Other information:
now ist (<right>info and <center>icons): http://img186.imageshack.us/img186/994/zrzutekranu2ep1.png must be(all <center>): http://img457.imageshack.us/img457/9862/zrzutekranu2rp3.png
I can confirm this for 2.18.0.1. Any hint which file to change to get old behavior back?
I confirm, same issue also in 2.19.4
Probably it's related to the PANGO_ELLIPSIZE_START and a missed alignment... but i'm not sure as I've no knowledges on Pango. Probably adding an alignment line should fix this
No the ellipsize start doesn't interess that bug :D
Created attachment 91278 [details] [review] Patch Index: src/nautilus-sidebar-title.c =================================================================== --- src/nautilus-sidebar-title.c (revisione 12983) +++ src/nautilus-sidebar-title.c (copia locale) @@ -670,7 +670,6 @@ gtk_label_set_justify (GTK_LABEL (title_label), GTK_JUSTIFY_CENTER); gtk_label_set_selectable (GTK_LABEL (title_label), TRUE); gtk_label_set_ellipsize (GTK_LABEL (title_label), PANGO_ELLIPSIZE_END); - gtk_misc_set_alignment (GTK_MISC (title_label), 0., 0.5); return title_label; } @@ -685,7 +684,6 @@ gtk_label_set_justify (GTK_LABEL (more_info_label), GTK_JUSTIFY_CENTER); gtk_label_set_selectable (GTK_LABEL (more_info_label), TRUE); gtk_label_set_ellipsize (GTK_LABEL (more_info_label), PANGO_ELLIPSIZE_END); - gtk_misc_set_alignment (GTK_MISC (more_info_label), 0., 0.5); return more_info_label; }
and this was the commit that causes the problem: http://svn.gnome.org/viewcvs/nautilus?view=revision&revision=11530 by the way i've no problems with long folders, as this still truncates the end of the word
Your patch indeed fixes the issue. The only thing I can't really understand is why the bug did not occur prior to 2.17-line. The stable 2.16 series includes above mentioned revision of nautilus-sidebar-title.c, but the bug is not present there. Any idea why?
I've said, the bug is due to http://svn.gnome.org/viewcvs/nautilus?view=revision&revision=11530 commit, which fixes long folders name in the sidebar, but as I said, removing the alignment part keep the things works without any issue
Thanks, it's on HEAD: 2007-07-10 Martin Wehner <martin.wehner@gmail.com> * src/nautilus-sidebar-title.c: (sidebar_title_create_title_label), (sidebar_title_create_more_info_label): Fix alignment of labels in information sidebar. (#414199) Patch from Andrea Cimitan <andrea.cimitan@gmail.com>