GNOME Bugzilla – Bug 414143
GdkPixbuf's GIF loader should set invalid delay times to 100ms, not 20ms
Last modified: 2010-07-10 04:09:27 UTC
Currently, when the GIF loader detects an invalid or too fast GIF delay time to 20ms. However, most other software that deals with rendering potentially invalid GIFs (such as Epiphany or Konqueror) set invalid delay times to 100ms instead. The result is that applications that use the GdkPixbufAnimation class appear to render GIFs "too fast", even though the GIF itself is at fault. I actually think that the algorithm should set invalid times (0ms) to 100ms, and merely too short times (<20ms) to 20ms. A time of 0ms is clearly erroneous, and should be corrected. However, a very short non-zero time indicates the author of the animation intended it to be fast. I have created two patches, one for the existing behaviour of other software, and another for the second correction system.
Created attachment 83789 [details] [review] Existing behaviour of Epiphany This patch uses the existing behaviour of Epiphany, which is to set any delay < 20ms to 100ms.
Created attachment 83790 [details] [review] Smart delay correction This patch uses "smart" delay correction, as outlined in the summary.
I don't think you'll be able to prove that "most other software" claim in any meaningful way. And I don't like the discontinuity of your proposed change.