After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 413123 - No XML dependency patch
No XML dependency patch
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.13
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-28 17:01 UTC by Mathieu Garcia
Modified: 2007-04-20 12:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
No XML dependency patch (4.59 KB, patch)
2007-02-28 17:02 UTC, Mathieu Garcia 		none Details | Review

Description Mathieu Garcia 2007-02-28 17:01:26 UTC 
"Beta" patch to remove the XML dependency.
When building with --disable-loadsave and --enable-binary-registry, you won't
need libxml2 anymore. If so, GST_DISABLE_LOADSAVE_REGISTRY will be defined, but
the define name isn't quite right. Maybe renaming it to GST_DISABLE_XML could
be better, but would break backward compatibility.
Comment 1 Mathieu Garcia 2007-02-28 17:02:08 UTC 
Created attachment 83551 [details] [review]
No XML dependency patch
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2007-04-18 13:28:51 UTC 
Wouldn't it be better
* to have GST_DISABLE_XML in gstconfig.h.in
* to remove the include from the config and include it where needed
  #ifndef GST_DISABLE_XML
  #include <libxml/parser.h>"
  #endif
* keep GST_DISABLE_LOADSAVE_REGISTRY for backwards compatibillity (add FIXME 0.11 comment)
Comment 3 Mathieu Garcia 2007-04-19 15:44:48 UTC 
Yes, this way the patch is even cleaner. I was just preserving backward compatibility but this is definitely something to be modified.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2007-04-20 06:51:10 UTC 
I don't think we need:

+if test "x$XML_DEP" = "xno"; then
+GST_ALL_CFLAGS="-I\$(top_srcdir)/libs -I\$(top_srcdir) -I\$(top_builddir) $GLIB_CFLAGS \$(GST_OPTION_CFLAGS)"
+else
 GST_ALL_CFLAGS="-I\$(top_srcdir)/libs -I\$(top_srcdir) -I\$(top_builddir) $GLIB_CFLAGS $XML_CFLAGS \$(GST_OPTION_CFLAGS)"
+fi

as if AG_GST_LIBXML2_CHECK(2.4.9) is not run, XML_CFLAGS is empty.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2007-04-20 10:45:05 UTC 
fixed in CVS as discussed.

@Mathieu, thanks for the patches still.