After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 412717 - Crash when opening a new tab with window maximized
Crash when opening a new tab with window maximized
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.15.x
Other All
: Normal critical
: ---
Assigned To: VTE Maintainers
VTE Maintainers
: 412977 413580 413581 413630 413893 415377 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-02-27 18:21 UTC by Adrien Cunin
Modified: 2007-03-06 16:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Ensure we don't set the current.row to -1 (559 bytes, patch)
2007-02-28 10:12 UTC, Chris Wilson
none Details | Review

Description Adrien Cunin 2007-02-27 18:21:10 UTC
Steps to reproduce:
1. Launch gnome-terminal
2. Maximize the window
3. File -> Open tab or Ctrl+Shift+T

Stack trace:
$ gdb gnome-terminal
GNU gdb 6.6-debian
Copyright (C) 2006 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i486-linux-gnu"...
Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
(gdb) run
Starting program: /usr/bin/gnome-terminal 
[Thread debugging using libthread_db enabled]
[New Thread -1227150736 (LWP 3143)]
[New Thread -1249793136 (LWP 3165)]

Program received signal SIGSEGV, Segmentation fault.

Thread NaN (LWP 3143)

  • #0 _vte_terminal_ensure_cursor
    at /home/adri2000/packaging/vte/vte-0.15.4/./src/vte.c line 1892
  • #1 _vte_terminal_insert_char
    at /home/adri2000/packaging/vte/vte-0.15.4/./src/vte.c line 2430
  • #2 vte_terminal_process_incoming
    at /home/adri2000/packaging/vte/vte-0.15.4/./src/vte.c line 3278
  • #3 time_process_incoming
    at /home/adri2000/packaging/vte/vte-0.15.4/./src/vte.c line 11919
  • #4 process_timeout
    at /home/adri2000/packaging/vte/vte-0.15.4/./src/vte.c line 11964
  • #5 ??
    from /usr/lib/libglib-2.0.so.0
  • #6 ??
The program is running.  Exit anyway? (y or n) y

Other information:
/home/adri2000/packaging/vte/ is where I built the vte packages with debugging symbols.

Ubuntu feisty, gnome-terminal 2.17.92-0ubuntu1, vte 1:0.15.4-0ubuntu1.
Comment 1 Chris Wilson 2007-02-27 19:09:45 UTC
Ok, this doesn't fall over for me.

As the implication is that row == NULL, it would be useful to check the value of screen->cursor_current.row and the contents of *screen->row_data.
Comment 2 Sebastien Bacher 2007-02-27 23:36:40 UTC
(gdb) p row
$1 = (VteRowData *) 0x0
(gdb) p screen->cursor_current.row
$2 = -1
(gdb) p *screen->row_data
$3 = {delta = 0, length = 0, max = 10000, cached_item = -1, cached_data = 0x0, array = 0x842e1e8, free = 0xb7dcae40 <vte_free_row_data>, user_data = 0x0}
Comment 3 Sebastien Bacher 2007-02-27 23:43:16 UTC
Ubuntu bug about that: https://beta.launchpad.net/vte/+bug/88489
Comment 4 Chris Wilson 2007-02-28 09:48:39 UTC
*** Bug 412977 has been marked as a duplicate of this bug. ***
Comment 5 Martin Pitt 2007-02-28 10:08:17 UTC
This is a recipe that resembles my actual production account:

- start with clean profile
- open terminal, open three more tabs
- gnome-save-session
- logout and back in, g-t opens briefly and crashes

"gnome-terminal --geometry 130x40" crashes immediately, but I didn't check whether it's the very same crash/root cause.
Comment 6 Chris Wilson 2007-02-28 10:12:27 UTC
Created attachment 83534 [details] [review]
Ensure we don't set the current.row to -1

This looks like the cause.
Comment 7 Chris Wilson 2007-02-28 10:15:40 UTC
Martin, 'gnome-terminal --geometry 130x40' was enough to trigger it for me and that patch does indeed prevent it.
Comment 8 Chris Wilson 2007-02-28 10:23:55 UTC
Hmm, along with bug 410534, I think I'll have to plead with Behdad for another brown-paper-bag release!

r1776: 2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 412717 – Crash when opening a new tab with window maximized

	* src/vte.c  (vte_terminal_size_allocate):
		We didn't carefully check the values we were clamping the
		cursor to and ended up setting it to -1...  Don't do that!

Comment 9 Chris Wilson 2007-03-01 20:26:44 UTC
*** Bug 413580 has been marked as a duplicate of this bug. ***
Comment 10 Chris Wilson 2007-03-01 20:27:40 UTC
*** Bug 413581 has been marked as a duplicate of this bug. ***
Comment 11 Florian Steinel 2007-03-01 21:09:50 UTC
verified fixed
Comment 12 Daniel Gryniewicz 2007-03-01 21:35:13 UTC
*** Bug 413630 has been marked as a duplicate of this bug. ***
Comment 13 Chris Wilson 2007-03-02 15:43:04 UTC
*** Bug 413893 has been marked as a duplicate of this bug. ***
Comment 14 Chris Wilson 2007-03-06 16:57:14 UTC
*** Bug 415377 has been marked as a duplicate of this bug. ***