After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 411975 - App icon cleanup and theming
App icon cleanup and theming
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: general
2.17.x
Other Linux
: Normal trivial
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-25 18:21 UTC by Michael Terry
Modified: 2007-05-15 00:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Proposed patch (35.18 KB, patch)
2007-02-25 18:23 UTC, Michael Terry
committed Details | Review

Description Michael Terry 2007-02-25 18:21:57 UTC
Inspired by the AppIcon Gnome Goal, I worked on using the icon theme for various application icons in gnome-media.  I also somewhat zealously cleaned up icons that didn't seem to be used anymore.  Let me know if I went too far.

Notes:
* Removed <icons>...</icons> from gnome-cd themes (was only in None theme).  Looks like this is old support for theming of UI widgets, but has since been replaced by proper theming.  It wasn't even being parsed by the XML parser.  I removed this XML chunk from the .theme and removed the icons.

* Got rid of gnome-mixer.png in favor of standard icon "multimedia-volume-control"

* gnome-grecord.png lives in both gnome-media and gnome-icon-theme.  I suspect it should just live in gnome-media, but I don't know policy on that kind of thing.

* gst-mixer and gnome-cd still use custom images (gst-mixer for an assortment of widget icons, see bug 310883; gnome-cd for its themes, see bug 353238).

* gstreamer-properties.png isn't namespaced well.  Shouldn't we use gnome-gstreamer-properties.png instead?

* The following files can be deleted:
 grecord/pixmaps/
 grecord/pixmaps/gnome_mixer.xpm
 gst-mixer/pixmaps/gnome-mixer.png
 gnome-cd/images/media/media-fwd.png
 gnome-cd/images/media/media-stop.png
 gnome-cd/images/media/a-stop-menu.png
 gnome-cd/images/media/media-eject.png
 gnome-cd/images/media/a-first-menu.png
 gnome-cd/images/media/a-eject-menu.png
 gnome-cd/images/media/media-rew.png
 gnome-cd/images/media/media-play.png
 gnome-cd/images/media/a-last-menu.png
 gnome-cd/images/media/a-play-menu.png
 gnome-cd/images/media/media-rec.png
 gnome-cd/images/media/media-prev.png
 gnome-cd/images/media/media-pause.png
 gnome-cd/images/media/media-next.png
 gnome-cd/images/media-eject.png
 gnome-cd/images/None/media-fwd.png
 gnome-cd/images/None/media-stop.png
 gnome-cd/images/None/a-stop-menu.png
 gnome-cd/images/None/a-first-menu.png
 gnome-cd/images/None/media-eject.png
 gnome-cd/images/None/media-rew.png
 gnome-cd/images/None/a-eject-menu.png
 gnome-cd/images/None/media-play.png
 gnome-cd/images/None/a-last-menu.png
 gnome-cd/images/None/a-play-menu.png
 gnome-cd/images/None/media-prev.png
 gnome-cd/images/None/media-pause.png
 gnome-cd/images/None/media-next.png
 gnome-cd/images/lcd/a-fwd.png
 gnome-cd/images/lcd/a-pause-pressed.png
 gnome-cd/images/lcd/a-fwd-pressed.png
 gnome-cd/images/lcd/a-first.png
 gnome-cd/images/lcd/a-first-menu.png
 gnome-cd/images/lcd/a-eject.png
 gnome-cd/images/lcd/a-first-pressed.png
 gnome-cd/images/lcd/a-eject-pressed.png
 gnome-cd/images/lcd/a-rwnd.png
 gnome-cd/images/lcd/a-rwnd-pressed.png
 gnome-cd/images/lcd/a-stop.png
 gnome-cd/images/lcd/a-stop-menu.png
 gnome-cd/images/lcd/a-stop-pressed.png
 gnome-cd/images/lcd/a-eject-menu.png
 gnome-cd/images/lcd/a-last.png
 gnome-cd/images/lcd/a-last-menu.png
 gnome-cd/images/lcd/a-play.png
 gnome-cd/images/lcd/a-last-pressed.png
 gnome-cd/images/lcd/a-play-menu.png
 gnome-cd/images/lcd/a-play-pressed.png
 gnome-cd/images/lcd/a-pause.png
 gnome-cd/images/mixer.png
 gnome-cd/images/a-play-menu.png
 gnome-cd/images/cd.png
 gnome-cd/images/red-lcd/a-fwd.png
 gnome-cd/images/red-lcd/a-pause-pressed.png
 gnome-cd/images/red-lcd/a-fwd-pressed.png
 gnome-cd/images/red-lcd/a-first.png
 gnome-cd/images/red-lcd/a-first-menu.png
 gnome-cd/images/red-lcd/a-eject.png
 gnome-cd/images/red-lcd/a-first-pressed.png
 gnome-cd/images/red-lcd/a-eject-pressed.png
 gnome-cd/images/red-lcd/a-rwnd.png
 gnome-cd/images/red-lcd/a-rwnd-pressed.png
 gnome-cd/images/red-lcd/a-stop.png
 gnome-cd/images/red-lcd/a-stop-menu.png
 gnome-cd/images/red-lcd/a-stop-pressed.png
 gnome-cd/images/red-lcd/a-eject-menu.png
 gnome-cd/images/red-lcd/a-last.png
 gnome-cd/images/red-lcd/a-last-menu.png
 gnome-cd/images/red-lcd/a-play.png
 gnome-cd/images/red-lcd/a-last-pressed.png
 gnome-cd/images/red-lcd/a-play-menu.png
 gnome-cd/images/red-lcd/a-play-pressed.png
 gnome-cd/images/red-lcd/a-pause.png

(I have SVN access to do the above if approved.)
Comment 1 Michael Terry 2007-02-25 18:23:04 UTC
Created attachment 83318 [details] [review]
Proposed patch
Comment 2 Marc-Andre Lureau 2007-05-13 12:50:38 UTC
(In reply to comment #1)
> Created an attachment (id=83318) [edit]
> Proposed patch
> 

Tested/Reviewed. Works fine on top of current trunk. Thanks! 
Patch looks good. Someone should apply. 
Comment 3 Michael Terry 2007-05-15 00:04:37 UTC
Committed as revision 3627.