Bug 410565 – gnome-terminal crashes editing current profile

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 410565 - gnome-terminal crashes editing current profile


Summary:	gnome-terminal crashes editing current profile


Status:	RESOLVED FIXED

Product:	gtk+
Classification:	Platform
Component:	Widget: GtkFileChooser
Version:	2.10.x
Hardware:	Other FreeBSD

Importance:	Normal critical
Target Milestone:	---
Assigned To:	gtk-bugs
QA Contact:	Federico Mena Quintero

URL:
Whiteboard:

Duplicates:	383516 412806 417294 (view as bug list)
Depends on:
Blocks:

Reported:	2007-02-21 22:20 UTC by Joe Marcus Clarke
Modified:	2007-12-24 22:02 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Attachments
Guard against an invalid path reference (1.91 KB, patch) 2007-02-22 01:27 UTC, Chris Wilson	none	Details \| Review

Description Joe Marcus Clarke 2007-02-21 22:20:19 UTC

This bug affects gnome-terminal 2.16.x as well, but since G_DEBUG is not set to fatal_criticals in GNOME 2.16, the crash is not seen.  The error on the console that is seen when trying to edit the current profile is:

(gnome-terminal:54546): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertion `path != NULL' failed

(gnome-terminal:54546): Gtk-CRITICAL **: gtk_list_store_set_valist: assertion `VALID_ITER (iter, list_store)' failed

(gnome-terminal:54546): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertion `path != NULL' failed

(gnome-terminal:54546): Gtk-CRITICAL **: gtk_list_store_set_valist: assertion `VALID_ITER (iter, list_store)' failed


The stack trace seen is:

+ Trace 112708

#0 kse_thr_interrupt
at kse_thr_interrupt.S line 2
#1 _thr_sig_add
at /usr/src/lib/libpthread/thread/thr_sig.c line 971
#2 _thr_sig_send
at /usr/src/lib/libpthread/thread/thr_sig.c line 1103
#3 _pthread_kill
at /usr/src/lib/libpthread/thread/thr_kill.c line 60
#4 _raise
at /usr/src/lib/libpthread/thread/thr_raise.c line 49
#5 abort
at /usr/src/lib/libc/stdlib/abort.c line 65
#6 IA__g_logv
at gmessages.c line 497
#7 IA__g_log
at gmessages.c line 517
#8 IA__g_return_if_fail_warning
at gmessages.c line 532
#9 IA__gtk_tree_model_get_iter
at gtktreemodel.c line 992
#10 change_icon_theme_get_info_cb
at gtkfilechooserbutton.c line 1220
#11 get_file_info_callback
at gtkfilesystemgnomevfs.c line 1467
#12 dispatch_job_callback
at gnome-vfs-job.c line 304
#13 g_idle_dispatch
at gmain.c line 3928
#14 IA__g_main_context_dispatch
at gmain.c line 2045
#15 g_main_context_iterate
at gmain.c line 2677
#16 IA__g_main_loop_run
at gmain.c line 2881
#17 IA__gtk_main
at gtkmain.c line 1148
#18 main
at terminal.c line 1773
#0 kse_thr_interrupt
at kse_thr_interrupt.S line 2
#1 _thr_sig_add
at /usr/src/lib/libpthread/thread/thr_sig.c line 971
#2 _thr_sig_send
at /usr/src/lib/libpthread/thread/thr_sig.c line 1103
#3 _pthread_kill
at /usr/src/lib/libpthread/thread/thr_kill.c line 60
#4 _raise
at /usr/src/lib/libpthread/thread/thr_raise.c line 49
#5 abort
at /usr/src/lib/libc/stdlib/abort.c line 65
#6 IA__g_logv
at gmessages.c line 497
#7 IA__g_log
at gmessages.c line 517
#8 IA__g_return_if_fail_warning
at gmessages.c line 532
#9 IA__gtk_tree_model_get_iter
at gtktreemodel.c line 992
#10 change_icon_theme_get_info_cb
at gtkfilechooserbutton.c line 1220
#11 get_file_info_callback
at gtkfilesystemgnomevfs.c line 1467
#12 dispatch_job_callback
at gnome-vfs-job.c line 304
#13 g_idle_dispatch
at gmain.c line 3928
#14 IA__g_main_context_dispatch
at gmain.c line 2045
#15 g_main_context_iterate
at gmain.c line 2677
#16 IA__g_main_loop_run
at gmain.c line 2881
#17 IA__gtk_main
at gtkmain.c line 1148
#18 main
at terminal.c line 1773

Comment 1 Chris Wilson 2007-02-22 01:27:04 UTC

Created attachment 83080 [details] [review]
Guard against an invalid path reference

Appears to a small oversight as the returns from all the other gtk_tree_row_reference_get_path() are properly checked.

Comment 2 Joe Marcus Clarke 2007-02-22 04:47:14 UTC

I tested this patch under GNOME 2.16, and the errors have gone away.  Gnome-terminal should no longer crash under GNOME 2.17.  Thanks!

Comment 3 Chris Wilson 2007-02-27 22:05:03 UTC

*** Bug 412806 has been marked as a duplicate of this bug. ***

Comment 4 Chris Wilson 2007-03-12 00:01:13 UTC

*** Bug 417294 has been marked as a duplicate of this bug. ***

Comment 5 Matthias Clasen 2007-03-12 04:14:58 UTC

2007-03-12  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkfilechooserbutton.c (change_icon_theme_get_info_cb):
        Handle the row reference path being NULL.  (#410565, Joe Markus
        Clarke, patch by Chris Wilson)

Comment 6 Jan Arne Petersen 2007-06-23 00:15:49 UTC

*** Bug 383516 has been marked as a duplicate of this bug. ***