Bug 409472 – crash in Sudoku: pressed Clear on one of ...

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 409472 - crash in Sudoku: pressed Clear on one of ...


Summary:	crash in Sudoku: pressed Clear on one of ...


Status:	RESOLVED FIXED

Product:	gnome-games-superseded
Classification:	Deprecated
Component:	gnome-sudoku
Version:	unspecified
Hardware:	Other All

Importance:	High blocker
Target Milestone:	gnome-2-18
Assigned To:	GNOME Games maintainers
QA Contact:	GNOME Games maintainers

URL:
Whiteboard:

Duplicates:	408760 409482 409987 410671 410675 410991 411069 411185 411917 411929 412093 412513 412613 412780 (view as bug list)
Depends on:
Blocks:

Reported:	2007-02-19 01:19 UTC by Josh Gunderson
Modified:	2007-02-27 21:59 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Attachments
proposed patch (677 bytes, patch) 2007-02-25 21:09 UTC, Andreas Røsdal	none	Details \| Review

Description Josh Gunderson 2007-02-19 01:19:56 UTC

What were you doing when the application crashed?
pressed Clear on one of the squares I had filled in


Distribution: Ubuntu 7.04 (feisty)
Gnome Release: 2.17.91 2007-02-12 (Ubuntu)
BugBuddy Version: 2.17.3

System: Linux 2.6.20-8-generic #2 SMP Tue Feb 13 05:18:42 UTC 2007 i686
X Vendor: The X.Org Foundation
X Vendor Release: 70101000
Selinux: No
Accessibility: Disabled

Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0
CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0



----------- .xsession-errors ---------------------
(gnome-about-me:7289): about-me-properties-WARNING **: EBookStatus returned 20
(gnome-about-me:7289): GConf-CRITICAL **: gconf_client_set_string: assertion `val != NULL' failed
There was an undetermined error
Traceback (most recent call last):

+ Trace 111887

File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1039 in entry_callback
```
self.remove(widget.x,widget.y)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1146 in remove
```
self.entry_validate(linked_entry)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1078 in entry_validate
```
self.__entries__[conflict].set_error_highlight(True)
```

KeyError: None

--------------------------------------------------
Traceback (most recent call last):

+ Trace 111887

File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1039 in entry_callback
```
self.remove(widget.x,widget.y)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1146 in remove
```
self.entry_validate(linked_entry)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1078 in entry_validate
```
self.__entries__[conflict].set_error_highlight(True)
```

KeyError: None

Comment 1 Susana 2007-02-19 13:36:34 UTC

*** Bug 409482 has been marked as a duplicate of this bug. ***

Comment 2 Susana 2007-02-21 08:36:30 UTC

*** Bug 409987 has been marked as a duplicate of this bug. ***

Comment 3 Damien Durand 2007-02-22 08:31:27 UTC

*** Bug 410671 has been marked as a duplicate of this bug. ***

Comment 4 Susana 2007-02-22 12:54:07 UTC

*** Bug 410675 has been marked as a duplicate of this bug. ***

Comment 5 Andreas Røsdal 2007-02-22 18:50:58 UTC

*** Bug 408760 has been marked as a duplicate of this bug. ***

Comment 6 Susana 2007-02-23 18:52:15 UTC

*** Bug 411185 has been marked as a duplicate of this bug. ***

Comment 7 Susana 2007-02-23 18:52:31 UTC

*** Bug 410991 has been marked as a duplicate of this bug. ***

Comment 8 Susana 2007-02-23 18:52:57 UTC

*** Bug 411069 has been marked as a duplicate of this bug. ***

Comment 9 Andreas Røsdal 2007-02-25 16:04:34 UTC

*** Bug 411917 has been marked as a duplicate of this bug. ***

Comment 10 Andreas Røsdal 2007-02-25 16:04:58 UTC

*** Bug 411929 has been marked as a duplicate of this bug. ***

Comment 11 Andreas Røsdal 2007-02-25 16:22:02 UTC

*** Bug 406649 has been marked as a duplicate of this bug. ***

Comment 12 Andreas Røsdal 2007-02-25 21:09:34 UTC

Created attachment 83327 [details] [review]
proposed patch

This is a proposed fix. It is not necessarily the best solution, but I the exception would be silenced. Thomas, do you have any comments? Should I commit this?

Comment 13 Thomas M. Hinkle 2007-02-25 21:24:19 UTC

I'm in the midst of a better fix as we speak which will not only get rid of the type error but clean up the code around it a bit.

Comment 14 Thomas M. Hinkle 2007-02-25 21:45:25 UTC

Ok -- I committed a better fix. My fix simplifies the code around this traceback considerably. While at it, I also found a typo that caused error-highlighting and unhighlighting not to work properly and could have resulted in finished games not registering as such.

Comment 15 Andreas Røsdal 2007-02-26 06:31:13 UTC

*** Bug 412093 has been marked as a duplicate of this bug. ***

Comment 16 Andreas Røsdal 2007-02-26 06:32:11 UTC

Thanks for fixing this bug, Thomas!

Comment 17 Susana 2007-02-27 11:26:31 UTC

*** Bug 412513 has been marked as a duplicate of this bug. ***

Comment 18 Pedro Villavicencio 2007-02-27 14:38:25 UTC

*** Bug 412613 has been marked as a duplicate of this bug. ***

Comment 19 Andreas Røsdal 2007-02-27 21:59:05 UTC

*** Bug 412780 has been marked as a duplicate of this bug. ***