After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 408906 - Add support for new titlebar actions
Add support for new titlebar actions
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
plumbing
Depends on:
Blocks: 408898
 
 
Reported: 2007-02-17 12:29 UTC by Christian Fredrik Kalager Schaller
Modified: 2011-03-18 02:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch from Linus (5.36 KB, patch)
2007-02-17 12:29 UTC, Christian Fredrik Kalager Schaller
none Details | Review
Adds the option for a mouse event to have no action (2.65 KB, patch)
2007-02-19 11:13 UTC, Charlie Brej
none Details | Review

Description Christian Fredrik Kalager Schaller 2007-02-17 12:29:02 UTC
Putting the patches created by Linus Torvalds into bugzilla so we can properly
track them accross involved modules. This is the Add-support-for-new-titlebar-actions control center patch.
Comment 1 Christian Fredrik Kalager Schaller 2007-02-17 12:29:28 UTC
Created attachment 82733 [details] [review]
Patch from Linus
Comment 2 Havoc Pennington 2007-02-18 01:49:26 UTC
looking at this, isn't opening a menu pretty deeply weird for a double click action? (maybe this would be clearer if I looked at the metacity part of the patch...)
Comment 3 Havoc Pennington 2007-02-18 01:53:35 UTC
I see the issue, the metacity code is trying to be all orthogonal and use the same enum of actions for single/double click... no reason to do that in the UI though, double click to open a menu makes no sense, so the menu item could be omitted from the control center.

Comment 4 Charlie Brej 2007-02-19 11:13:17 UTC
Created attachment 82876 [details] [review]
Adds the option for a mouse event to have no action

Adds the option for a mouse event to have no action ("None"). Also removes a couple warnings about casting into enum pointers.
Comment 5 Elijah Newren 2007-02-20 05:25:21 UTC
See bug 154614 comment 3; in my opinion, that should be done first before this option is added.
Comment 6 Thomas Wood 2007-02-21 23:24:55 UTC
Confirming bug report, since no one has objected. Also cleaning up the summary.
Comment 7 Bastien Nocera 2011-03-17 12:31:47 UTC
Deep Metacity configuration, to gnome-tweak-tool.
Comment 8 John Stowers 2011-03-18 02:32:35 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.