After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 407315 - Use wide character Win32 API in the pangowin32 code
Use wide character Win32 API in the pangowin32 code
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: win32
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
pango-maint
Depends on: 110521
Blocks:
 
 
Reported: 2007-02-13 02:50 UTC by Tor Lillqvist
Modified: 2007-02-27 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Suggested implementation (34.79 KB, patch)
2007-02-13 02:52 UTC, Tor Lillqvist 		none Details | Review

Description Tor Lillqvist 2007-02-13 02:50:17 UTC 
It would be a good idea to use the wide character API in the Win32 code in Pango. Cetainly in trunk (and possibly even in 1.14) we don't need to care for Win9x any longer, so no use to keep diddling with the system codepage font names. Unfortunately the LOGFONT struct (implicitly meaning the ANSI version, LOGFONTA) is used in some public Pango API, so we have to keep those entry points. We should however plan on eventually deprecating them and introduce corresponding new functions that use LOGFONTW instead. The old functions can be made into wrappers that convert the LOGFONTA back and forth to LOGFONTW and call the new LOGFONTW using ones.

The private pangowin32 API also has some functions using LOGFONTA, but as this is private API, we by definition don't have to keep it stable.
Comment 1 Tor Lillqvist 2007-02-13 02:52:14 UTC 
Created attachment 82434 [details] [review]
Suggested implementation

Only slightly tested with gtk-demo so far.
Comment 2 Tor Lillqvist 2007-02-13 03:33:41 UTC 
Hmm, actually that patch wasn't tested at all, and doesn't work... (GI thought I tested it, but as the previously built pango DLLs were in the same folder as gtk-demo.exe, that overrode my PATH setting;) Will attach a new diff once I've found the problem.
Comment 3 Tor Lillqvist 2007-02-26 00:34:51 UTC 
Newer version of the patch in bug #110521.
Comment 4 Tor Lillqvist 2007-02-27 09:26:46 UTC 
Fixed now in trunk (i.e. 1.16 branch at this point).