GNOME Bugzilla – Bug 404739
Disable Import Of Sticky Notes Option If None Exist
Last modified: 2008-02-27 01:30:54 UTC
The way it works now, the option is always enabled and then checks for data to import after selecting the option. Software should do the reverse, and not present options that will produce an error dialog. Check for the directory in advance, and then gray out that option if non exist.
Created attachment 81958 [details] [review] Patch to remove Import menu option if no sticky notes exist (untested) Added an untested patch to only add the Import menu option if the sticky notes XML file exists. Will test it when I get back to my Linux box. If there is no sticky notes XML file, then this plug-in is wasting resources checking for files whenever it's initialized. Should it disable itself if this happens? If a user starts with Tomboy, tries the Sticky Notes applet, and then wants to migrate those new notes to Tomboy, is it OK that they would then have to manually re-enable the plug-in in Tomboy's preferences?
Created attachment 81979 [details] [review] Updated patch - only checks for file existence once. Updated (and tested) patch. This version only checks for Sticky Notes XML file existence on Initialize once per Tomboy session. I would commit this, but I'm not sure if it counts as a new feature, and I don't want to break any freezes.
I didn't mention, but this patch also moves the generation of the Sticky Notes XML fie path to a static member so it is only done once.
Committed patch to SVN. Calum Benson suggested that we have a single Import dialog that can work on multiple sources, in which case the "Import" menu item would always exist. Good idea if we get support for more import sources in the future.
Reverted change in behavior. UI freeze break was not approved. Will put this in after 0.6.0 branches.
Received approval, patch reapplied as of svn rev 969. Closing this bug.
Marking this as fixed/closed in the 0.5.9 release.
Modifying default assignee and qa contact to be tomboy-maint@gnome.bugs.