Created attachment 81785 [details] [review]
proposed patch

what about page setup? we also need page setup in evince to print the document. I prefer --print-settings instead of just --settings. 

The page setup is a bit of a problem: which one? It can be modified for each page by the request-page-setup signal handler...

I've committed the support for %s in gtk-print-preview-command.
I haven't changed the default value, since evince doesn't seem
to support --print-settings yet.

2007-04-29  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkprintoperation-unix.c
        (_gtk_print_operation_platform_backend_launch_preview):
        Support passing a print settings file to the preview
        command.  (#403717, Christian Persch)

        * gtk/gtksettings.c: Document %s in the
        gtk-print-preview-command setting.

Created attachment 88007 [details] [review]
Patch

Evince has now support for --print-settings, so here is the trivial patch for the Makefile.am.

FWIW, if I'm not mistaken Evince 0.9.0 already has --print-settings support, so there's a released version we can use.

from evince 0.9.0 help output:

Application Options:
  -p, --page-label=PAGE          The page of the document to display.
  -f, --fullscreen               Run evince in fullscreen mode
  -s, --presentation             Run evince in presentation mode
  -w, --preview                  Run evince as a previewer
  --display=DISPLAY              X display to use


...doesn't look like it.

That's not surprising, since --print-settings is a G_OPTION_FLAG_HIDDEN option. It's definitely present in 0.9.0.

Odd. Is there any good reason for that ? 

Anyway, go ahead and commit then, but also add a note to README.in about this,
please.

All the print preview related options are hidden, since they're not useful for normal operation.


        * gtk/Makefile.am: Pass the print settings to the preview programme.
        Bug #403717, patch by Carlos Garcia Campos.

Can we have the note in README.in too, please ?

Added a note.