After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 399705 - use standard icon sizes in the UI
use standard icon sizes in the UI
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other All
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-23 09:15 UTC by Jakub Steiner
Modified: 2007-07-15 21:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jakub Steiner 2007-01-23 09:15:00 UTC 
F-Spot currently uses non standard size of 20x20 pixels for the editing toolbar. This poses potential problems when using the icons alongside the standard toolbar icons (22x22px) making either of those fuzzy due to scaling and filtering.
Comment 1 Larry Ewing 2007-01-23 21:13:59 UTC 
I'm using IconSize.Button should I be using IconSize.SmallToolbar?
Comment 2 Jakub Steiner 2007-01-24 10:57:31 UTC 
If that's either 16x16, 22x22 or 24x24, please do. I'll fix up the icons soon afterwards.
Comment 3 Stephane Delcroix 2007-01-25 13:31:26 UTC 
IconSize.Menu resolves to 16px
SmallToolbar => 18px
Button => 20px
LargeToolbar => 24px
Comment 4 Jakub Steiner 2007-01-25 14:34:40 UTC 
I suggest going to LargeToolbar or Menu then.


Generally, we aught to do some thresholding in gtk. Scaling a 22x22px bitmap into 20x20 is a sin! We only have 16x16, 22x22, 32x32 bitmaps in our icon themes. We render the 24x24px out of the 22x22px as GNOME is using 24x24, but this really should be done in gtk:

16x16 .. 21x21 > 16x16px bitmap (add padding, no scaling)
22x22 .. 31x31 > 22x22px bitmap (no scaling)
32x32 .. 47x47 > 32x32px bitmap (no scaling)
48x48 .. > SVG (scalable)
Comment 5 Stephane Delcroix 2007-07-15 07:39:38 UTC 
jimmac, is that problem addressed now with the themable branch merged in ?
Comment 6 Jakub Steiner 2007-07-15 21:05:22 UTC 
Yes, indeed. This is now fixed. Thanks