After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 396261 - imagemap plug-in has invalid source in (generated?) file
imagemap plug-in has invalid source in (generated?) file
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other Windows
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2007-01-13 22:49 UTC by Hans Breuer
Modified: 2007-01-15 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Hans Breuer 2007-01-13 22:49:52 UTC
there is a stray semicolon in file plug-ins/imagemap/imap_csim_parse.c which break the build on win32 with msvc. The following patch would fix it:

Index: plug-ins/imagemap/imap_csim_parse.c
===================================================================
--- plug-ins/imagemap/imap_csim_parse.c	(Revision 21704)
+++ plug-ins/imagemap/imap_csim_parse.c	(Arbeitskopie)
@@ -1037,7 +1037,7 @@
 #else
 int
 yyparse ()
-    ;
+/*    ;   */
 #endif
 #endif
 {
Comment 1 Sven Neumann 2007-01-14 10:35:55 UTC
The file is generated. You need to fix the problem in the file(s) that it is generated from.
Comment 2 Hans Breuer 2007-01-14 14:26:01 UTC
AFAIK the failing part comes from a template file distributed with bison, not from anything in the gimp source tree. The stray semicolon got added with the following comment:

2006-05-12  Michael Natterer  <mitch@gimp.org>

	* plug-ins/imagemap/imap_csim_parse.[ch]: regenerated (using
	bison 2.1 instead of 2.0, lots of things changed, please test).

One way to fix that may be to simply use bison 2.2, or maybe not. I've just tried but the stray semicolon persists. So the next step is to write a mail to bug-bison@gnu.org ?
Comment 3 Kevin Cozens 2007-01-14 19:49:25 UTC
When the file is generated with bison 2.3 (under FC6) I don't get that extra ; being reported. Get a newer copy of bison or modify your /usr/share/bison/yacc.c file.
Comment 4 Sven Neumann 2007-01-14 22:49:48 UTC
We should regenerate the files in SVN using bison 2.3 then.
Comment 5 Sven Neumann 2007-01-15 10:11:21 UTC
2007-01-15  Sven Neumann  <sven@gimp.org>

	* plug-ins/imagemap/imap_csim_lex.c
	* plug-ins/imagemap/imap_ncsa_parse.[ch]
	* plug-ins/imagemap/imap_ncsa_lex.c
	* plug-ins/imagemap/imap_cern_lex.c
	* plug-ins/imagemap/imap_csim_parse.[ch]
	* plug-ins/imagemap/imap_cern_parse.[ch]: regenerated using GNU
	Bison 2.3.  Should fix bug #396261.