After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395584 - Document frame text is skipped when reviewing in Firefox
Document frame text is skipped when reviewing in Firefox
Status: RESOLVED FIXED
Product: lsr
Classification: Deprecated
Component: core
0.3.x
Other Linux
: Normal normal
: 0.4.0
Assigned To: Scott Haeger
LSR maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-11 21:43 UTC by Scott Haeger
Modified: 2007-01-15 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test webpage that illustrates problem (493 bytes, text/plain)
2007-01-11 21:45 UTC, Scott Haeger
  Details
fix for Document frame text is skipped when reviewing in Firefox (2.70 KB, patch)
2007-01-12 15:29 UTC, Scott Haeger
committed Details | Review

Description Scott Haeger 2007-01-11 21:43:23 UTC
Text that is contained in the document frame, such as <body>some text</body> or <body><span>some more text</span></body>, is skipped when reviewing in the forward direction.
Comment 1 Scott Haeger 2007-01-11 21:45:07 UTC
Created attachment 80076 [details]
test webpage that illustrates problem
Comment 2 Peter Parente 2007-01-12 05:10:54 UTC
Here's a starting point. Remember that a POR consists of an accessible, item offset, and character offset. For simple widgets (e.g. a button), item offset is always None. For widgets that can contain other transient widgets, the item offset of None refers to the container while integer item offsets refer to the child items.

Typically, in review mode, the walk order goes

some previous accessible
this POR with item offset None
this POR with item offset 0
this POR with item offset 1
...
this POR with last item offset
some next accessible

The item text of the POR(acc, None, 0) is the name of the accessible. For a tree control, for instance, saying the item text for POR(tree_acc, None, 0) would attempt to say the name of the tree widget itself where as POR(tree_acc, i, 0) would attempt to say the text of item #i.

Hypertext is not a simple widget and has items. The items in a hypertext accessible are:

1) Runs of text not containing an embed character
2) Child accessibles represented by the embed character in the parent hypertext

In the hypertext case, we do *not* want to ever say the item text of POR(hypertext_acc, None, 0). Why? Because the accessible name of a block of hypertext is rarely (never?) used. All that's important is the item text.

The Adapters for Hypertext try to account for this difference by always skipping the None case in the forward walk and moving right to POR(hypertext_acc, 0, 0). Apparently, some cases are not handled properly and the POR(hypertext_acc, None, 0) case is getting announced and, worse, the POR(hypertext_acc, 0, 0) case is being skipped in passing directly to POR(hypertext_acc, 1, 0) during some walks.
Comment 3 Scott Haeger 2007-01-12 15:29:31 UTC
Created attachment 80115 [details] [review]
fix for Document frame text is skipped when reviewing in Firefox

Patch includes changes from bug 383000.  Reviewing with Alt-Shift-U,I,O,F,H passes all 6 test webpages given on bug 383000 plus gedit and random widgets in gtk-demo.
Comment 4 Peter Parente 2007-01-15 14:20:30 UTC
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.