After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 393697 - Theme packages should has their own mime type.
Theme packages should has their own mime type.
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
git master
Other All
: Normal enhancement
: ---
Assigned To: Thomas Wood
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-06 22:44 UTC by Alberto Ruiz
Modified: 2007-03-02 02:02 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Partial mime definition patch (3.36 KB, patch)
2007-01-06 23:11 UTC, Alberto Ruiz
reviewed Details | Review
Mime type definition (3.77 KB, patch)
2007-01-06 23:26 UTC, Alberto Ruiz
none Details | Review
Mime type definition (4.36 KB, patch)
2007-01-06 23:44 UTC, Alberto Ruiz
none Details | Review
Mime type definition (4.36 KB, patch)
2007-01-08 00:49 UTC, Alberto Ruiz
none Details | Review
Mime type definition (4.34 KB, patch)
2007-01-08 07:39 UTC, Alberto Ruiz
committed Details | Review
Installer .gtp extension check. (816 bytes, patch)
2007-01-08 21:50 UTC, Alberto Ruiz
committed Details | Review
Fixes on the suffix checks. (1.49 KB, patch)
2007-01-26 04:55 UTC, Alberto Ruiz
none Details | Review
Fixes on the suffix checks. (1.74 KB, patch)
2007-01-26 04:58 UTC, Alberto Ruiz
committed Details | Review

Description Alberto Ruiz 2007-01-06 22:44:59 UTC
Theme packages would be easier to install if they has their own mime type so people can double click them (right now, if users doble click the tar.gz they see the details of the .tar.gz trough the file-roller).
Comment 1 Alberto Ruiz 2007-01-06 23:11:17 UTC
Created attachment 79580 [details] [review]
Partial mime definition  patch

I patched Makefile.am almost blindly (copypasting from nautilus examples), it needs to be seriously reviewed.
Comment 2 Thomas Wood 2007-01-06 23:16:11 UTC
Thanks Alberto. The patch looks reasonable, and I'll apply it after some testing.
Comment 3 Alberto Ruiz 2007-01-06 23:26:17 UTC
Created attachment 79582 [details] [review]
Mime type definition

Improved version of the patch, fixes AC_CONFIG_FILES on configure.in
Comment 4 Alberto Ruiz 2007-01-06 23:44:30 UTC
Created attachment 79584 [details] [review]
Mime type definition

Fixed inclusion of the new files in POTFILES.in
Comment 5 Alberto Ruiz 2007-01-08 00:49:05 UTC
Created attachment 79699 [details] [review]
Mime type definition

fixes configure.in problem
Comment 6 Alberto Ruiz 2007-01-08 07:39:23 UTC
Created attachment 79718 [details] [review]
Mime type definition

fixes problems in the .desktop file, the NoDisplay key is not needed and may cause problems
Comment 7 Rodrigo Moya 2007-01-08 21:46:29 UTC
Closing, already applied
Comment 8 Alberto Ruiz 2007-01-08 21:50:24 UTC
Created attachment 79789 [details] [review]
Installer .gtp extension check.

Adds .gtp extension check to the installer source code.
Comment 9 Thomas Wood 2007-01-08 22:48:28 UTC
Comitted, thanks.
Comment 10 Rodney Dawes 2007-01-11 14:28:04 UTC
I really wish that the MIME type were under some class other than application/. A theme tarball is in fact, NOT an application. Maybe x-theme/gnome-theme-package or something would be better.

I know application is basically a dumping ground for random crap and that's probably where most other themes have ended up putting their MIME types, but we should try to make it easier to do generics for things, rather than dumping everything we come up with, under application.
Comment 11 Alberto Ruiz 2007-01-12 00:37:21 UTC
Tar.gz files aren't applications either, and uses application/x-compressed-tar (that's why I choosed applications) is there any MIME naming "best practices" documentation somewhere?
Comment 12 Ross Burton 2007-01-12 09:42:08 UTC
From RFC 2046, which defines the MIME type system

4.5.  Application Media Type

   The "application" media type is to be used for discrete data which do
   not fit in any of the other categories, and particularly for data to
   be processed by some type of application program.  This is
   information which must be processed by an application before it is
   viewable or usable by a user.

Defining new media types is a bold move.

However, as the MIME type isn't registered, it should be application/x-gnome-theme-package.
Comment 13 Alberto Ruiz 2007-01-26 04:55:16 UTC
Created attachment 81250 [details] [review]
Fixes on the suffix checks.

Fixes the miss of checking ".gtp" suffix when remote installing (drag and drop from the browser) and replaces hardcore suffix checks with g_str_has_suffix from glib.
Comment 14 Alberto Ruiz 2007-01-26 04:58:57 UTC
Created attachment 81251 [details] [review]
Fixes on the suffix checks.

Update the from the previous fix. Removing the length variable used to check the suffix.
Comment 15 Thomas Wood 2007-01-26 17:34:14 UTC
2007-01-26  Thomas Wood  <thos@gnome.org>

        Patch by: Alberto Ruiz <aruiz@synaptia.net>

        * gnome-theme-installer.c: (transfer_done_cb),
        (gnome_theme_install_from_uri): Fixes on the suffix checks.
Comment 16 John Nilsson 2007-03-02 02:02:52 UTC
Isn't it kind of broken to have one and only one mime type for a file?

Why not <name>.gtp.tar.gz

With a type expressing that it's:
1. a gzip compressed representation
2. of a tar archive
3. containing a gnome theme

like application/x-gnome-theme; archive=application/x-tar; compression=application/x-gzip

I mean why should the gnome theme spec contain mandated archiving or compression choices?