After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 393527 - GStreamer settings variables untranslated
GStreamer settings variables untranslated
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gstreamer-properties
2.17.x
Other All
: Normal normal
: 2.17.3
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-06 14:52 UTC by Gabor Kelemen
Modified: 2007-01-07 19:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Trivial fix (6.04 KB, patch)
2007-01-06 14:53 UTC, Gabor Kelemen
needs-work Details | Review

Description Gabor Kelemen 2007-01-06 14:52:06 UTC
Please describe the problem:
Filed originally as:

https://bugzilla.novell.com/show_bug.cgi?id=220302

Image of untranslated strings:
https://bugzilla.novell.com/attachment.cgi?id=104865&action=view

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Gabor Kelemen 2007-01-06 14:53:15 UTC
Created attachment 79528 [details] [review]
Trivial fix
Comment 2 Ronald Bultje 2007-01-06 16:39:00 UTC
In gstreamer-properties.c, line 540, please change the _() into a gettext(), since it's not a static string and even if it was, we don't want to mark it, since your patch already marks them for translation. After that, feel free to apply.
Comment 3 Ronald Bultje 2007-01-06 18:38:57 UTC
2007-01-06  Ronald S. Bultje,,,  <rbultje@gnome.org>

        * gstreamer-properties/gstreamer-properties.c:
        (create_pipeline_menu):
          Use gettext(), not _(), since it's not a constant string.
        * gstreamer-properties/pipeline-constants.c:
          Mark pipeline descriptors for translation, patch provided by
          Gabor Kelemen <kelemeng@gnome.hu> (#393527).
Comment 4 Gabor Kelemen 2007-01-07 14:02:53 UTC
Thanks for the quick response. Could you commit this to gnome-2-16 branch too? 
Comment 5 Ronald Bultje 2007-01-07 18:37:45 UTC
Are there any releases left for 2.16? I thin it'd be easier to just continue on the 2.18 track...

If you insist, feel free to apply (I don't have a 2.16 checkout and don't yet know how to checkout branches with svn).
Comment 6 Gabor Kelemen 2007-01-07 19:28:00 UTC
Yes, http://live.gnome.org/TwoPointSeventeen says 2.16.3 is due at the end of this month. 

I'm going to backport this to 2-16 branch.

About basics of svn, here is a good tutorial:
http://developer.gnome.org/tools/svn.html