After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 393204 - gnome-open does not open URL's with commas in Firefox 2.0.0.1
gnome-open does not open URL's with commas in Firefox 2.0.0.1
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-05 17:04 UTC by Chris Mayo
Modified: 2008-04-18 23:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Fix for Firefox commands (11.33 KB, patch)
2007-01-06 14:24 UTC, Philip Withnall 		committed Details | Review

Description Chris Mayo 2007-01-05 17:04:28 UTC 
The entries in gnome-default-applications.xml.in for Firefox do not support URL's with commas in v.2.0.0.1:

firefox -remote (mozilla-xremote-client) no longer works on urls containing commas, and is deprecated. firefox -new-window /url/ will open the url in a new window; firefox -new-tab /url/ will open the url in a new tab.
(http://www.mozilla.com/en-US/firefox/2.0.0.1/releasenotes/#whatsnew)
Comment 1 Philip Withnall 2007-01-06 14:24:11 UTC 
Created attachment 79527 [details] [review]
Fix for Firefox commands

Patch to fix Firefox commands.

Here's the Firefox upstream bug report for failure to handle commas and quotes:
https://bugzilla.mozilla.org/show_bug.cgi?id=298960
Comment 2 Luca Cavalli 2007-01-06 14:46:15 UTC 
Confirming since Firefox official release notes report this too.
Philip, is your fix backward compatible with Firefox 1.x? I tested the -new-tab and -new-window options with 1.5.0.6 and it seems to work, but older versions?
Comment 3 Luca Cavalli 2007-01-06 14:58:42 UTC 
BTW, this would probably fix bug 370779 too.
Comment 4 Philip Withnall 2007-01-28 13:49:09 UTC 
Sorry for not responding. I didn't realise I wasn't on the CC list!

I don't think this fix is actually backwards-compatible with 1.0.x, but it should be OK for 1.5 as you found. The -new-window option was available in 1.0.x (I think), but the -new-tab option was added later.
Comment 5 Rodrigo Moya 2007-08-21 11:49:48 UTC 
Patch committed, although not sure if we should provide a backwards compatible entry for 1.0.x ?
Comment 6 Philip Withnall 2007-08-27 15:22:19 UTC 
I don't think it's worth it; Firefox 1.0 is no longer maintained.
Comment 7 Thomas Wood 2008-04-18 23:09:11 UTC 
Closing bug as per previous comment(s).