Bug 392313 – [directdrawsink] dist and add to gst-plugins-bad

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 392313 - [directdrawsink] dist and add to gst-plugins-bad


Summary:	[directdrawsink] dist and add to gst-plugins-bad


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-bad
Version:	git master
Hardware:	Other Windows

Importance:	Normal normal
Target Milestone:	0.10.5
Assigned To:	Tim-Philipp Müller
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-01-03 14:11 UTC by Vincent Torri
Modified:	2007-01-03 19:55 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch that adds the compilation of directdrawsink (4.75 KB, patch) 2007-01-03 14:12 UTC, Vincent Torri	committed	Details \| Review
Makefile.am for the compilation of directdrawsink plugin (449 bytes, text/plain) 2007-01-03 14:13 UTC, Vincent Torri		Details

Description Vincent Torri 2007-01-03 14:11:44 UTC

I've added the compilation of directdrawsink in gst-plugins-bad.
there are below the patch that:
* adds a check in configure.ac for some win32 header files and libs
* adds the compilation in sys/Makefile.am
* fixes warnings in gstdirectdrawsink.c

Also, I've added the needed Makefile.am below

Comment 1 Vincent Torri 2007-01-03 14:12:26 UTC

Created attachment 79275 [details] [review]
patch that adds the compilation of directdrawsink

Comment 2 Vincent Torri 2007-01-03 14:13:13 UTC

Created attachment 79276 [details]
Makefile.am for the compilation of directdrawsink plugin

Comment 3 Tim-Philipp Müller 2007-01-03 19:55:23 UTC

Thanks, committed:

 2007-01-03  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Vincent Torri  <vtorri at univ-evry fr>

        * configure.ac:
        * sys/Makefile.am:
        * sys/directdraw/Makefile.am:
          Add directdrawsink to build and dist it, so it gets built when
          compiling with MingW on win32 and the required headers and libraries
          are available (fixes: #392313).

        * sys/directdraw/gstdirectdrawsink.c:
        (gst_directdrawsink_center_rect), (gst_directdrawsink_show_frame),
        (gst_directdrawsink_setup_ddraw),
        (gst_directdrawsink_surface_create):
          Comment out some unused things and fix some printf format issues in
          order to avoid warnings when buildling with MingW (#392313).