GNOME Bugzilla – Bug 389197
Kill bonobo?
Last modified: 2007-01-22 14:20:56 UTC
gthumb uses some kind of bonobo magic to expose itself as a bonobo component. But, AFAIK, bonobo is going to be deprecated and nobody likes bonobo anymore. Plus, there are no apps that actually use gthumbs bonobo component for anything. So I wonder, would it be a good idea to try and get rid of all bonobo parts from gthumb?
It has already been removed from CVS HEAD, as of 2006-11-30. - Mike
It still has many references to bonobo. See for example http://cvs.gnome.org/viewcvs/gthumb/src/main.c?rev=1.56&view=markup.
Yes, you are right. I should have said that the process of removing bonobo has started. Clean-up patches are welcome :-) - Mike
Here is an attempt to remove as much bonobo (and IDL and Orbit) as possible. I also deleted some bonobo-specific files and cvs diff can't handle changes like that. * data/GNOME_GThumb.server.in.in * src/GNOME_GThumb.idl * src/gth-application.c * src/gth-application.h OT, but am I the only one finding it mildly ironic that the almost extinct ape is being exterminated in the GNOME project? :)
Created attachment 79082 [details] [review] Remove bonobo stuff from gThumb Apply with "patch < name-of-it.patch -p0" in the root directory.
Patch committed to svn (hopefully I did it right - we just switched from cvs). Thank you for the patch! - Mike
Please revert this change, bonobo is still used to provide a single instance application.
Patch reverted as requested. - Mike
The gtkunique module can be used to provide a single instance application. Once the migration to gtkunique is completed it will be possible to remove the bonobo dependency.
Sorry, I misunderstood the code! - Mike
ok, the patch has been committed now, and, as anticipated above, gtkunique is now used to provide a single instance application. In the near future I'll make the gtkunique dependency (and the feature it provides) optional.
Paolo, What is happening with gtkunique 1.0 - how are users supposed to get it? I only see it in svn (no 1.0 .tar.gz release files?). - Mike
I think the 1.0 version will be released soon, it's also very likely that gtkunique will be included in gtk+ itself in the next development cycle of gtk+.