GNOME Bugzilla – Bug 387652
Fix some object reference counting issues
Last modified: 2006-12-28 18:24:07 UTC
GossipJabber is never finalized at gossip's exit so we don't see many refcount errors. GossipTelepathy seems better refcounted and is finalized at exit, but it lead to many bugs because some objects are too much unreffed in libgossip/UI.
Created attachment 78652 [details] [review] proposed patch Here is a patch with some fixes. It's already committed into TELEPATHY branch, I don't have time to test it enough in HEAD. Can someone play with it some times and tell me if it can be committed without breaking everything ? Thanks.
Created attachment 78654 [details] [review] better like that Thanks to Richard for pointing me that chatroom might not be in the lists.
committed.
Should the signal be emitted if the list wasn't in the list?
If the room wasn't in the list, I mean :)
hm, I don't really know, if the room isn't in the list I guess it's because we call gossip_chatroom_manager_remove twice with the same room, so I guess the signal shouldn't be emitted twice. Good point.
Xavier, PLEASE PLEASE! Do not commit patches like this without my or other lead developers review to HEAD. You asked me to review it and I haven't got around to it yet, that doesn't mean it is OK to commit. To refrain from spending my time fixing regressions that you commit, Can you please wait next time and let me test it for a few days in HEAD before it is committed. Please don't do this again.
Created attachment 78736 [details] [review] emit chatroom-removed only if it's really removed from lists patch to fix Richard's comment.
Thanks Richard and Xavier :)