GNOME Bugzilla – Bug 385872
Have epiphany install it's own icon
Last modified: 2007-07-14 22:39:55 UTC
Currently, Epiphany is using the /apps/web-browser icon from gnome-icon-theme as application icon. Epiphany is the only browser using this icon, all the other web-browsers install their own icons. Therefore I suggest that we move this icon from gnome-icon-theme and have epiphany install it in hicolor (named epiphany though, not the generic web-browser).
Created attachment 78366 [details] application icon Here is the application icon.
Do we absolutely have to name it "epiphany" or can we keep "web-browser"? (Otherwise we'll need some code changes).
It needs to be named epiphany. What if some other app was actually called "web-browser" and wanted to install an icon. We'd have a nasty conflict then. Being the default browser for GNOME doesn't mean that every aspect of it should be as generic as possible. It can cause a lot of potential conflicts in the case of large apps like this.
Agree, in any case we can install a symbolic link?
Installing a symlink into hicolor is no better than just installing the icon as that name, and it doesn't make sense. There's no need for the symlink, given that no other apps should be depending on epiphany's icon. Every other web browser uses its own icon anyway, so having a web-browser symlink doesn't really solve any problems. Old versions of epiphany will require old versions of gnome-icon-theme to have the icon show up properly. I don't think that's really an issue that we need to come up with a solution for.
chpe: how big are the code changes? The only thing I can think of from the top of my head is the desktop-file. I can fix you up with a correct one in that case.
Created attachment 78423 [details] New epiphany.desktop file modified desktop-file
I fixed the code; all you have to do is change EPHY_STOCK_EPHY define in lib/ephy-stock-icons.h. > What if some other app was actually called > "web-browser" and wanted to install an icon. We'd have a nasty conflict then. If that's all it takes, I could rename ephy to web-browser.
(In reply to comment #8) > > What if some other app was actually called > > "web-browser" and wanted to install an icon. We'd have a nasty conflict then. > > If that's all it takes, I could rename ephy to web-browser. > Naming apps generic things is dumb. Yeah, there's a certain amount of usability value for some simpler applications, but for web browsers and things, it's more of a usability hindrance. Brand recognition is valuable, and actually enhances usability in a lot of cases, despite how much some people want to believe it doesn't. Anyway, I'm attaching a patch that changes all of THREE whole lines, in all of the files in the epiphany/ source tree, to rename the icon from web-browser to epiphany. I'm sure it would take a lot more than 3 lines of changes to rename the whole application, properly anyway.
Created attachment 78432 [details] [review] Patch to change web-browser icon name to epiphany
So, OK to move (or copy) "web-browser" icon from g-i-t to Epiphany source and rename it "epiphany"? We just have to add "apps" directories in data/icons/<size> and use as Makefile.am: ################# START of Makefile.am themedir = $(datadir)/icons/hicolor size = 16x16 context = apps iconsdir = $(themedir)/$(size)/$(context) icons_DATA = \ epiphany.png noinst_DATA = EXTRA_DIST = \ $(icons_DATA) \ $(noinst_DATA) gtk_update_icon_cache = gtk-update-icon-cache -f -t $(datadir)/icons/hicolor install-data-hook: @-if test -z "$(DESTDIR)"; then \ echo "Updating Gtk icon cache."; \ $(gtk_update_icon_cache); \ else \ echo "*** Icon cache not updated. After install, run this:"; \ echo "*** $(gtk_update_icon_cache)"; \ fi #################### END Plus, of course, Rodney's patch.
Christian, changing the status to NEW means we can rename the icon? If so, I'll do it.
Moving to 2.20 target due to feature and UI freeze for 2.18.
It's ok to copy the icon into epiphany if g-i-t absolutely needs to remove it. Do retain the name though.
The name should be epiphany. Epiphany should not install a "web-browser" icon. Nor should any icon be named "web-browser" really. I don't understand why you are so against naming the icon as it should rightfully be named.
New "epiphany" icon is now on trunk. Pending stuff: * missingg 32x32 version (I copied from g-i-t, 32x32 should be in Andreas' package in comment #1). I'll add ASAP * maybe we need more branding ??
Pending stuff * use new icon here: data/chrome/about.xhtml
2007-07-11 Luca Ferretti <elle.uca@libero.it> * data/chrome/about.xhtml: Use new "epiphany" icon here (thanks to Rodney Dawes). * data/icons/32x32/apps/Makefile.am: * data/icons/32x32/apps/epiphany.svg: * data/icons/32x32/apps/epiphany.svg: Add 32x32 pixel icon (thanks to Andreas Nilsson). This commit should fix this bug. Anything pending?