After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 384008 - [xvimagesink] accesses ->xwindow outside locks
[xvimagesink] accesses ->xwindow outside locks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-09 11:05 UTC by Jonathan Matthew
Modified: 2007-01-08 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a few fixes (1.84 KB, patch)
2006-12-09 11:08 UTC, Jonathan Matthew 		none Details | Review

Description Jonathan Matthew 2006-12-09 11:05:23 UTC 
xvimagesink accesses ->xwindow in a few places without holding either flow_lock or x_lock.  I think this is causing the "CRITICAL **: gst_xvimagesink_xvimage_put: assertion `xvimagesink->xwindow != NULL' failed" messages I get while setting a new output window ID.
Comment 1 Jonathan Matthew 2006-12-09 11:08:26 UTC 
Created attachment 78012 [details] [review]
a few fixes

There appear to be more unprotected accesses, but I don't really understand the various locks used in xvimagesink, so I've left them alone.  So far, this seems to fix the problem I was having.

I haven't checked ximagesink for similar issues.
Comment 2 René Stadler 2006-12-09 14:55:49 UTC 
See also: Bug #384060
Comment 3 Julien MOUTTE 2007-01-07 18:51:20 UTC 
Fixed in CVS HEAD. Please try it and reopen the bug if it's still not ok for you.