After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 382692 - libbonoboui doesn't build with Quartz GDK backend
libbonoboui doesn't build with Quartz GDK backend
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonoboui
CVS HEAD
Other Mac OS
: Normal normal
: ---
Assigned To: Michael Meeks
bonobo qa
Depends on:
Blocks:
 
 
Reported: 2006-12-05 18:37 UTC by Min Sik Kim
Modified: 2006-12-14 09:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Patch to build libbonoboui with Quartz GDK backend (1.83 KB, patch)
2006-12-05 18:40 UTC, Min Sik Kim
none Details | Review

Description Min Sik Kim 2006-12-05 18:37:26 UTC
Building libbonoboui with Quartz GDK backend causes an error because several files contain the following lines:

#if defined (GDK_WINDOWING_X11)
#include <gdk/gdkx.h>
#elif defined (GDK_WINDOWING_WIN32)
#include <gdk/gdkwin32.h>
#else
#error Port to this GDK backend
#endif

A workaround is to add a case for GDK_WINDOWING_QUARTZ to bonobo-canvas-item.c, bonobo-control.c, bonobo-control-frame.c, and bonobo-plug.c as follows:

#if defined (GDK_WINDOWING_X11)
#include <gdk/gdkx.h>
#elif defined (GDK_WINDOWING_WIN32)
#include <gdk/gdkwin32.h>
#elif defined (GDK_WINDOWING_QUARTZ)
#else
#error Port to this GDK backend
#endif
Comment 1 Min Sik Kim 2006-12-05 18:40:10 UTC
Created attachment 77745 [details] [review]
Patch to build libbonoboui with Quartz GDK backend
Comment 2 Kjartan Maraas 2006-12-09 19:13:55 UTC
Michael, could you take a look at this?
Comment 3 Michael Meeks 2006-12-11 17:08:12 UTC
Sure - looks reasonable to me.
Of course - while the capability to use a remote plug/socket and the X protocol to proxy drawing is all there, in reality I don't think it's actually used in anger across the desktop that much (if at all).

So - you can prolly get away on Quartz without the plug/socket stuff and all should be well for (eg. Evolution).
Comment 4 Kjartan Maraas 2006-12-14 09:26:17 UTC
I commited this.