GNOME Bugzilla – Bug 382495
orca --setup is not localized
Last modified: 2006-12-06 13:45:36 UTC
orca needs to define textdomain for glade. To reproduce: 1. Invoke orca --setup the window pop up successfully ,but it is wholely unlocalized. I'm attaching the patch.
Created attachment 77707 [details] [review] Patch for src/orca/orca_i18n.py.in Attached the patch.
Thankyou! Patch checked in CVS HEAD. Closing bug as FIXED. This just missed the Orca 2.17.3 tarball release on Sunday, but will appear in the 2.17.4 release in about 2-3 weeks time.
Created attachment 77756 [details] [review] Reworked patch. On trying this with a supposedly running version of Orca (i.e. one that didn't require --setup), Will found that the original patch didn't work (gtk.glade wasn't loaded at that time). I've reworked the patch and checked it into CVS HEAD. It works for me. Will, if it still doesn't work for you, please let me know. Thanks.
Your change is also ok however I guess your failure was caused by missing 'import gtk.glade' below. % cvs diff -r1.3 -r1.4 src/orca/orca_i18n.py.in Index: src/orca/orca_i18n.py.in =================================================================== RCS file: /cvs/gnome/orca/src/orca/orca_i18n.py.in,v retrieving revision 1.3 retrieving revision 1.4 diff -r1.3 -r1.4 37a38,39 > gtk.glade.bindtextdomain ("@GETTEXT_PACKAGE@", localedir) > gtk.glade.textdomain("orca") I think the try & except are not needed. Please double check my original patch. Thanks.
> I think the try & except are not needed. Please double check my original patch. There are times where the user runs the orca command w/o the DISPLAY being set. A common example includes configuring orca for the first time by running it from a virtual console using brltty. In these cases, an import of gtk{.glade} will cause warnings or other things to be presented on the console. As such, we wrap the import of gtk in try/except statements to prevent the user from getting these warnings.
You're right. Thanks for your explanation.