After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 380944 - [dvdec] Doesn't set pixel-aspect-ratio
[dvdec] Doesn't set pixel-aspect-ratio
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-30 16:25 UTC by Edward Hervey
Modified: 2007-03-09 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to improve negotiation (7.19 KB, patch)
2007-03-02 14:40 UTC, Wim Taymans 		none Details | Review

Description Edward Hervey 2006-11-30 16:25:56 UTC 
dvdec assumes that the pixel-aspect-ratio property on the caps will be set by upstream elements, which is true for DV in DV system streams. But if that stream is contained in an AVI or a Quicktime file, the demuxer will not set the pixel-aspect-ratio.

This causes problems since the outgoing caps will not have PAR, which means that the display aspect ratio will be wrong (it can be seen quite clearly with widescreen DV files).

The libdv API offers enough to actually figure out what PAR should be set (the same logic is done in dvdemux in fact).
Comment 1 Wim Taymans 2007-03-02 14:40:14 UTC 
Created attachment 83733 [details] [review]
Patch to improve negotiation

Please test this patch.
Comment 2 Jan Schmidt 2007-03-09 17:33:41 UTC 
Committed after fixing a trivial crash and logic error. Tested with all DV files I have handy, some in AVI and some straight DV.

        * ext/dv/gstdvdec.c: (gst_dvdec_init), (gst_dvdec_sink_setcaps),
        (gst_dvdec_src_negotiate), (gst_dvdec_chain),
        (gst_dvdec_change_state):
        * ext/dv/gstdvdec.h:
        Infer pixel-aspect-ratio from the video frame format if it isn't
        provided by the container, as happens when playing DV from AVI
        or Quicktime containers.

        Patch by: Wim Taymans <wim@fluendo.com>
        Fixes #380944