GNOME Bugzilla – Bug 380644
"Required Participants" dialog does not show meeting participants
Last modified: 2013-09-13 00:49:57 UTC
Forwarding this from a downstream bug report: http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215467 Confirmed that this still exists in Evolution 2.9.2. Steps to Reproduce: 1. Launch Evolution's Calendar component. 2. Create a new meeting and add a few participants. 3. Save the meeting, then re-open it from the calendar. 4. Click the "Attendees" button to bring up the "Required Participants" dialog. Actual Results: There are no participants listed in the "Required Participants" dialog. Closing this dialog then updates the participant list in the "Meeting" dialog, which effectively blows away all the participants. Expected Results: The participants listed in the "Meeting" dialog should be listed in the appropriate section(s) of the "Required Participants" dialog.
Created attachment 78179 [details] [review] Proposed patch This patch keeps the "Required Participants" dialog up-to-date by connecting the EMeetingListView to the EMeetingStore's "row-inserted" and "row-deleted" signals and then forwarding those events to the ENameSelector. It has one known side-effect. The following warning is generated for each participant when opening a meeting from the calendar: e-data-server-ui-WARNING **: Same destination added more than once to EDestinationStore! I've not yet traced the root cause of this warning, but it seems harmless.
On opening the editor, e_meeting_store_add_attendee updates the store with the current set of attendees. The callback you have added in your patch updates the store again (e_destination_store_append_destination) - which is the source of the warning. The patch looks fine otherwise.
Harish, thanks for the tip. I'll get the warning fixed before committing.
So, are you going to commit this?
Yes. I still want to try to get the warning fixed first.
Matthew, can you look at this?
Created attachment 97897 [details] [review] proposed evo patch for evolution; There was similar issue in task-editor too, so I changed it on both places. Because everything else work like expected, so I drop Matt's solution with attached signals, instead of that I added new functions to add attendees to name selector and name store in one place, so we keep consistent. Remove attendee in task-editor was broken too, so fixed now. From original patch I kept two Matt's changes, I named it code cleanup, even I'm not sure why he did there those changes.
Milan, I tested your patch also. it works fine and no warnings or anything. Commit to stable/head (Since no string changes)
Committed to trunk. Committed revision 34582. Committed to stable. Committed revision 34583.
*** Bug 436615 has been marked as a duplicate of this bug. ***