GNOME Bugzilla – Bug 379611
Color Balance "range" handled incorrectly.
Last modified: 2006-11-27 10:08:27 UTC
Please describe the problem: In the Color Balance tool, the option to select the "Range to Adjust" (shadows|midtones|highlights) does not properly differentiate between the "highlights" and the "midtones". Steps to reproduce: 1. Duplicate a layer 2. Apply some extreme Color balance settings to the Midtones of one of the layers. 3. Apply the same settings to the Highlights of the other layer. Actual results: There is very little difference between the two different layers. Expected results: The two different operations would effect two noticeably different results. Does this happen every time? Yes. Other information: A "cut-n-paste" typographical error seems to have been introduced into the function 'color_balance_transfer_init()' in the file "app/base/color-balance.c". A simple patch will be forthcoming.
Created attachment 77179 [details] [review] Proposed fixed. This patch implements the function in what I think to be the manner originally intended.
Created attachment 77183 [details] [review] Amended patch I overlooked what appears to be an indexing problem for the existing code as well. Note: I am confident that the pre-existing behavior of this filter is anomalous; however, I am not at all certain that my patch implements things as the original programmer intended.
I think you are right. Thanks for spotting this. I have committed a somewhat cleaner version that should be easier to understand and harder to get wrong.