Created attachment 77172 [details] [review]
gossip-tp-avatars-groups

Here is the patch. I can commit it once reviewed.

Thanks for this wonderful work !

I moved groups stuffs into his own module gossip-telepathy-groups.[ch]. I also did a code cleanup (indentation,etc).

TelepathyChannelGroupChangeReason seems to not be defined, I renamed it to TelepathyGroupsChangeReason to keep the TelepathyGroups prefix and to not have something too long. I guess that's what's missing:

typedef enum
{
	TELEPATHY_GROUPS_CHANGE_REASON_NONE
	TELEPATHY_GROUPS_CHANGE_REASON_OFFLINE
	TELEPATHY_GROUPS_CHANGE_REASON_KICKED
	TELEPATHY_GROUPS_CHANGE_REASON_BUSY
	TELEPATHY_GROUPS_CHANGE_REASON_INVITED
	TELEPATHY_GROUPS_CHANGE_REASON_BANNED
	TELEPATHY_GROUPS_CHANGE_REASON_ERROR
} TelepathyGroupsChangeReason;

The problem is it doesn't compiles with the actual libtelepathy, it needs an update I guess. So I didn't tested (not event compiled) your work yet, I'll test with development libtp as soon as I've time, but I think we should wait for a release before committing into TELEPATHY branch.

I'll attach my changes as soon as I'm sure it at least compiles :-)

Committed !

I moved groups stuff to his own module, made all avatar calls async and cleaned the code a bit. It seems to work perfectly...

Avatar support is being reviewed for inclusion into gabble and groups support still needs more work, so atm nothing works out-of-the-box... but gossip is ready for when gabble/butterfly/etc will get support for that.

I hugs Raphael for his wonderful works !