After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 377100 - [PATCH] Add FreeBSD support to nautilus-cd-burner
[PATCH] Add FreeBSD support to nautilus-cd-burner
Status: RESOLVED OBSOLETE
Product: nautilus-cd-burner
Classification: Deprecated
Component: cd-burner
2.16.x
Other FreeBSD
: Normal major
: ---
Assigned To: Nautilus CD Burner Maintainers
Nautilus CD Burner Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-19 19:00 UTC by Joe Marcus Clarke
Modified: 2009-08-20 14:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Fix n-c-b's FreeBSD support (9.57 KB, patch)
2006-11-19 19:03 UTC, Joe Marcus Clarke
needs-work Details | Review

Description Joe Marcus Clarke 2006-11-19 19:00:54 UTC
Please describe the problem:
Now that n-c-b relies on HAL to obtain a list of available drives, FreeBSD support is broken.  The cdrtools (e.g. cdrecord, cdrdao, readcd, etc.) do not yet support opening device files on FreeBSD.  Thus, when these tools are called with -dev=/dev/cd0, they fail.  FreeBSD still requires the old x,x,x notation.  Not to worry.  Our HAL backend knows about this, and provides properties.  However, n-c-b needs to be taught to use these properties.

To that end, I have added a new private drive struct member: cdrecord_device.  On non-FreeBSD platforms, this will be a dup of device.  However, on FreeBSD, this will be the old bus,target,lun string.  The attached patch adds FreeBSD functionality while preserving Linux and Solaris functionality.

Steps to reproduce:
1. Try to burn a CD on FreeBSD using n-c-b
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Note: we cannot simply but the x,x,x string in device since this will break applications like sound-juicer which can handle opening the device file.
Comment 1 Joe Marcus Clarke 2006-11-19 19:03:05 UTC
Created attachment 76856 [details] [review]
Fix n-c-b's FreeBSD support
Comment 2 Bastien Nocera 2006-11-19 23:09:31 UTC
Wouldn't it be better to have a "block.cdrecord_device" property in HAL, rather than special-casing in the applications?
Comment 3 Joe Marcus Clarke 2006-11-20 00:04:37 UTC
See my extra note at the bottom.  If I did this, then applications like sound-juicer that also use n-c-b will fail since x,x,x is meaningless to them.  They prefer to open the actual device.  Sounds n-c-b needs to be able to tell the difference between the cdrecord device and the regular block device.  You can call it whatever you want in HAL (we called it block.freebsd.cam_path), but either way, n-c-b needs extra logic to know when to use this property vs. the actual device.
Comment 4 William Jon McCann 2006-12-04 19:59:29 UTC
Unfortunately we'll have to figure out a better way than exposing cdrecord details through the API.  I don't want to have a cdrecord_device property.
Comment 5 Fabio Bonelli 2008-12-16 18:38:20 UTC
Joe, is this still valid?

http://www.freebsd.org/gnome/docs/faq2.html#q15 makes me belive that n-c-b usually works well on FreeBSD. 
Comment 6 Joe Marcus Clarke 2008-12-16 19:14:06 UTC
It does only because I have been maintaining the patches in this bug locally.  n-c-b does not work out-of-the-box on FreeBSD since our cdrecord implementation does not support the dev= notation.
Comment 7 joerg.schilling 2009-07-01 20:19:47 UTC
Note that there is a GStreamer plugin for sound-juicer
that is based on cdda2wav. It gives better quality
and it avoids the license problems from using libcdio.

I did write this library together with Sun, check it....
it of course supports the offcial dev= syntax instead of the
deprecated dev=/dev/* syntax.


Comment 8 Bastien Nocera 2009-07-29 10:47:46 UTC
nautilus-cd-burner has been replaced by Brasero in the GNOME 2.26 release. If your bug still applies to Brasero, please feel free to re-open the bug, and reassign it to brasero itself.
Comment 9 joerg.schilling 2009-07-29 11:10:55 UTC
This is not a problem that goes away woth Brasero.

You would need to use the official cdrtools software
instead of the broken fork wodim and you need to implement
support to deal with the results from a cdrecord -scanbus 
output. This is a method that is portable to a lot more
platforms than the method brasero currently uses.

Note tha cdrtools offers a de-facto platform independence
and ports to many more plaforms than Brasero currently does.
By using the methods from cdrtools to get the needed information,
Brasero would become more portable.
Comment 10 Bastien Nocera 2009-07-29 11:25:57 UTC
Stop spamming bugzilla with your cdrtools adverts.
Comment 11 joerg.schilling 2009-07-29 12:26:24 UTC
Please stop sending your anti-social spam.

I am giving real help to the Authors of brasero.
If you don't understand this help, this is your problem.

Comment 12 Bastien Nocera 2009-07-29 12:45:32 UTC
This isn't a forum, and it's not appropriate for you to spam every bug with block assertions that so and so's software is broken. Work with distributions on getting your tools in their distros if you actually want to do something.

And for what it's worth, I know how to behave on the GNOME bugzilla, seeing as I posted more than 16 thousand comments on it.
Comment 13 joerg.schilling 2009-07-29 16:04:24 UTC
Posting 16 thousand reports does not verify that you have the needed skills.

If you don't understand that I am helping with understanding
a specific bug, please contact me offline. A bug tracking system
is not the appropriate place to allow you to understand things
that are unrelated to this bug nor to send your propaganda
that looks very anti-social to me. If you carefully read my 
comments on the various bugs here, you will see that I only
comment bugs that are based on well known bugs from specific
versions of a software. Giving hints on more up-to date versions
of the software is one of the basic ideas for a bug tracking system.



Comment 14 Olav Vitters 2009-08-20 14:22:03 UTC
Joerg: You've been banned from GNOME Bugzilla. Please refrain from using any GNOME resources, thanks.