GNOME Bugzilla – Bug 376287
Vino shows the wrong host in 2.17.2
Last modified: 2009-09-30 14:05:54 UTC
Please describe the problem: When a user tries to access my desktop, vino shows a host like '::400:0'. That's wrong. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 76754 [details] [review] Proposed patch
John: cool stuff, it looks like the right approach Comments: - I don't think we want to use NI_NOFQDN - I think we do actually want to display the fqdn if we can - I'm a little worried about the portability of sockaddr_storage and getnameinfo() ... but I guess we'll just fix it if and when people run into problems building on crufty platforms :-) - Just delete the rfbSockaddrToHostname() function - Don't comment out code ... just delete it - add a new line between getpeername() and getnameinfo() to make things easier to read ... also, perhaps wrap some of the getnameinfo() args to the next line Once you've fixed up those, and your CVS account is activated ... just go ahead and commit
2006-11-17 Jonh Wendell <jwendell@cvs.gnome.org> Fixes bug #376287 - Vino shows the wrong host in 2.17.2 * vino/server/libvncserver/rfbserver.c : remove rfbSockaddrToHostname() function and updated rfbNewClient() so that it gets the right ip/name from remote machine.
What was the patch applied to solve this? The patch attached to this bug has the tag 'needs-work', so I guess that this is not the bug solver, although it's appear to do what the changelog say.
Carlos, try to navigate in svn/git history to get the commit in this date. I've got this: http://git.gnome.org/cgit/vino/commit/?id=8882f606a9c9843780164b1c9c2f7cbd7adfec32