After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 374698 - Check of a contact == NULL
Check of a contact == NULL
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: Telepathy
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-13 14:36 UTC by Sjoerd Simons
Modified: 2006-11-15 23:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.14 KB, patch)
2006-11-13 14:36 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2006-11-13 14:36:13 UTC 
It can happen that a handle can't be translated into a contact. Attached patch adds checks for this in various places. Some way to report errors back to the user should probably be added where it makes sense
Comment 1 Sjoerd Simons 2006-11-13 14:36:44 UTC 
Created attachment 76487 [details] [review]
Proposed patch
Comment 2 Xavier Claessens 2006-11-15 23:09:18 UTC 
commited, thanks.

I just removed gossip_debug() messages since the error is reported by gossip_telepathy_get_contact_from_handle(). I also changed a g_return_val_if_fail() to a simple return since g_return print a useless critical warning message, if we want a warning we can put a g_warning in gossip_telepathy_get_contact_from_handle().