GNOME Bugzilla – Bug 374623
Clearlooks hangs ephy
Last modified: 2006-11-17 18:02:36 UTC
gtk2-engines-2.8.0-1.fc6 After restarting epiphany after a crash, the pages wouldn't load anymore. Clearlooks/cairo shows that it's hanging trying to draw things. Switching to "Bluecurve" as the theme made the pages appear straight away. A couple of backtraces attached:
+ Trace 86021
I don't see anything wrong in these stack traces. Looks like Clearlooks is redrawing the notebook tabs for the throbber animation. As I understand it, everything is working as expected. Clearlooks redraws the tabs for the throbber animation and the ui is still responding. Is that right?
(In reply to comment #1) > I don't see anything wrong in these stack traces. Looks like Clearlooks is > redrawing the notebook tabs for the throbber animation. Yep. > As I understand it, everything is working as expected. Clearlooks redraws the > tabs for the throbber animation and the ui is still responding. Is that right? Certainly not working as expected. It might only be a performance problem, but there's no page data. Switching gtk+ themes made all the pages show up.
So this is a performance issue. What seems to happen is that the timeout for the animation has a higher priority than doing any work to load the pages. So as soon as drawing the animation uses up all the available cpu power no page load can happen. While clearlooks could use some optimizations, I think this should be solved in epiphany. Optimizing clearlooks will only increase the number of open tabs needed to get into this situation.
I see no evidence of the spinner being responsible here, how do you came to that conclusion? (The timeout is installed in lib/widgets/ephy-spinner.c:ephy_spinner_start.) In my opinion, this is https://bugzilla.mozilla.org/show_bug.cgi?id=352096 coupled with the fact that showing the 1st ephy window causes a style reset somehow.
Well, I have no problem reproducing this by just opening a lot of windows with tabs fast (hit ctrl+t a lot and ctrl+n every once in a while). After a short time so many tabs are open that the cpu load goes to 100%. At that point, nothing loads. Then if I close some tabs the pages load.
(In reply to comment #5) > Well, I have no problem reproducing this by just opening a lot of windows with > tabs fast (hit ctrl+t a lot and ctrl+n every once in a while). > After a short time so many tabs are open that the cpu load goes to 100%. At > that point, nothing loads. Then if I close some tabs the pages load. And does it load again if you change themes?
(In reply to comment #6) > And does it load again if you change themes? Only if I change to a less intensive theme. Change to Raleigh, it works, to some pixmap theme, nothing changes ... I just tried changing the priority of the animation timeout (which defaults to G_PRIORITY_DEFAULT) to G_PRIORITY_LOW. This fixed the issue for me.
Created attachment 76565 [details] [review] patch to ephy-spinner.c that changes the animation priority
Thanks for the patch, please commit to HEAD and gnome-2-16.
Commited to both HEAD and gnome-2-16.