After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 373557 - duplicated sort functions, date sort improvement
duplicated sort functions, date sort improvement
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.9.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2006-11-10 21:02 UTC by Michael Chudobiak
Modified: 2006-11-18 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Chudobiak 2006-11-10 21:02:26 UTC 
The comp_func* sorting functions are present in many gthumb files.

They should be consolidated into a gth-sort-utils.c file in libgthumb.

Also, I propose that the comp_func_time function be modified to use the Exif date, if present. If it isn't present, then it would use the filesystem modified date. Most people care more about the Exif date. This would require the Exif date to be added to the FileData structure.

- Mike
Comment 1 Michael Chudobiak 2006-11-10 22:12:56 UTC 
On second thought, maybe the date-sort scheme should be controlled by a preference (filesystem date, or Exif datetime with fallback to filesystem date).
Comment 2 Michael Chudobiak 2006-11-17 20:40:37 UTC 
I have moved the basic sort routines to gth-sort-utils.c.

No changes to date logic have been made yet.

- Mike
Comment 3 Michael Chudobiak 2006-11-18 13:56:20 UTC 
I have added a separate sort by Exif DateTime tag mode. (Those with no DateTime tag have a time of "0", and are sorted by name.)

To be committed shortly.