GNOME Bugzilla – Bug 372820
First call to PKG_CHECK_MODULES is conditional without a prior call to PKG_PROG_PKG_CONFIG
Last modified: 2006-11-28 14:04:17 UTC
First call to PKG_CHECK_MODULES in eog's configure.in is conditional, but PKG_PROG_PKG_CONFIG isn't called beforehand. pkg.m4 says: # Note that if there is a possibility the first call to # PKG_CHECK_MODULES might not happen, you should be sure to include an # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac Without the PKG_PROG_PKG_CONFIG various issues can happen on some systems in this case (first check_modules is conditional).
Created attachment 76253 [details] [review] Patch used in Gentoo Linux This patch is used in Gentoo since eog-2.11.90, added to the package tree by Leonardo Boshell. Forwarding it here now :)
I'm not sure if that's the optimal solution as it makes configure check for pkg-config twice here. As far as I know PKG_PROG_PKG_CONFIG is called by GNOME_DOC_INIT (gnome-doc-utils >= 0.3.3).
Ah, I missed that one. Seems that GNOME_DOC_INIT was added on 22nd March 2006 with migration to g-d-u, and so is part of eog-2.16, but we've kept carrying the patch on without noticing this hidden fix. I'll be satisfied with a comment in configure.in that says that GNOME_DOC_INIT has to come before the conditional checks, due to this. Just to ensure that things don't break when someone thinks GNOME_DOC_INIT is more suitable in the end of the file :) Might just as well move a non-conditional PKG_CHECK_MODULES above the conditional ones.
Two more possible alternatives that I thought about now: * Just put PKG_PROG_PKG_CONFIG more to the beginning, above even GNOME_DOC_INIT * Just close this bug without doing anything else
(In reply to comment #3) > Ah, I missed that one. > Seems that GNOME_DOC_INIT was added on 22nd March 2006 with migration to g-d-u, > and so is part of eog-2.16, but we've kept carrying the patch on without > noticing this hidden fix. > Remember that you need to depend on gnome-doc-utils >= 0.3.3 if you don't use your patch (the PKG_PROG_PKG_CONFIG call was added there).
Okay, I commited a combined approach. It moves GNOME_DOC_INIT down so it comes directly before the other pkg-config tests. And to be on the save side (and correct if g-d-u < 0.3.3) call PKG_PROG_PKG_CONFIG just before it. Thanks for reporting. Commited to HEAD and eog-ng branches: 2006-11-28 Felix Riemann * configure.in: Put GNOME_DOC_INIT down further and make sure PKG_PROG_PKG_CONFIG is called before any other PKG_CHECK_MODULES call. Fixes bug #372820.