After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 371838 - header pane not updated when a score matches on bytes or lines
header pane not updated when a score matches on bytes or lines
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other All
: Normal normal
: 1.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2006-11-07 02:33 UTC by Mike
Modified: 2007-02-09 06:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test patch #1 (6.01 KB, patch)
2007-02-04 21:17 UTC, Charles Kerr
committed Details | Review
previous patch had a bug... this should be applied on top of it (1.89 KB, patch)
2007-02-06 01:43 UTC, Charles Kerr
committed Details | Review

Description Mike 2006-11-07 02:33:16 UTC
Please describe the problem:
New articles don't appear in the header pane if the Score file contains a rule matching on a minimum of bytes or lines.

Steps to reproduce:
1. Articles -> Add a Scoring Rule
2. Group name contains ., Line Count is at most 275, Then Ignore the article
3. Load an active group


Actual results:
New headers are downloaded and the article count in the group pane increases, but the header pane is empty (or doesn't show new articles). New articles will show up if Pan is exited and the group is selected or another group is viewed and you immediately switch back.

Expected results:
New articles shown

Does this happen every time?
Yes

Other information:
[*.*]
Score: =-9999
~Lines: 275

[*.*]
Score: =-9999
~Bytes: 8192

This is not a problem with 0.14
Comment 1 Charles Kerr 2007-02-04 20:11:44 UTC
Codewise, this is one ugly bug. =(
Comment 2 Charles Kerr 2007-02-04 21:17:04 UTC
Created attachment 81893 [details] [review]
test patch #1

This fixes it, but it needs to be tested more
to ensure there aren't any side-effects.
Comment 3 Charles Kerr 2007-02-04 22:56:06 UTC
Works For Me (tm).  Since I'll be rolling a new beta
tomorrow to fix 0.122's build issues, I might as well
include this in that release.
Comment 4 Mike 2007-02-05 20:39:30 UTC
I don't see it in 0.122, but I applied the patch and it seems to work ok.

Thanks
Comment 5 Charles Kerr 2007-02-05 21:46:59 UTC
Well I'm rolling the new version to fix an error in 0.122...
Comment 6 Charles Kerr 2007-02-06 01:43:06 UTC
Created attachment 81969 [details] [review]
previous patch had a bug... this should be applied on top of it
Comment 7 Mike 2007-02-09 03:52:46 UTC
It seems to me that 0.123 is now showing all new articles, regardless of score. The score is only applied if you change groups. Anyone else see this? Could it be part of the new patch? I don't recall this behavior with the first one.
Comment 8 Charles Kerr 2007-02-09 04:03:37 UTC
Seems to be working for me, with some simple testing of 
`match only watched articles' + `show matching articles'
does what you'd expect.

What behavior are you seeing?
Comment 9 Mike 2007-02-09 06:28:34 UTC
I'm certain I tested the first patch against 0.122 with success at work, but I'm unable to get anything working at home. It's as if nothing has changed at all, I can't explain it.

I've uninstalled my debian package, wiped my ~/.pan and ~/.pan2, compiled and tested both 0.122 (with both patches) and 0.123, verified the versions in Help -> About. When I load any of the comp.os.linux groups with a Score of:

[*.*]
Score: =-9999
~Lines: 100

[*.*]
Score: =-9999
Subject: [Ll]inux

and the default View -> Header matches, every new article shows up. If I right click -> Edit Score or read the article, the matching -9999 is clearly visible. As mentioned in comment 0, switching to another group and back again applies the scores.

I can't help but feel I'm doing something wrong, but I've gone over this several times now and don't see what the problem is. Am I crazy? :/