After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 369210 - The relation of Label_For/Labeled_By is missing in account setting window.
The relation of Label_For/Labeled_By is missing in account setting window.
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: Accessibility
2.0.x
Other All
: Normal enhancement
: 3.40
Assigned To: Jan Schampera
Depends on:
Blocks:
 
 
Reported: 2006-11-02 03:11 UTC by Tim Miao
Modified: 2009-04-05 21:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Test for explicit ATK support. (7.04 KB, patch)
2006-12-31 10:59 UTC, Jan Schampera
needs-work Details | Review
Fixes the account dialogs (2.75 KB, patch)
2009-03-06 01:01 UTC, Eugen Dedu
none Details | Review

Description Tim Miao 2006-11-02 03:11:43 UTC
Please describe the problem:
This is an a11y bug for ekiga blind access.

Steps to reproduce:
1. Enable desktop accessibility support.
2. Invoke ekiga, select top menu Edit->Account.
3. Click Add button in account window.
4. Invoke at-poke and track the structure tree to each text label and text entry or combobox.


Actual results:
The relation of Label_For/Labeled_By is missing between text label and text entry/combobox.

Expected results:
The relation of Label_For/Labeled_By should be there so that at-tools(orca) could report the label of each widget for user.

Does this happen every time?
Yes.

Other information:
No.
Comment 1 Tim Miao 2006-11-02 04:04:35 UTC
This bug is also visible in address book properties window.
Comment 2 Jan Schampera 2006-12-31 10:59:55 UTC
Created attachment 79090 [details] [review]
Test for explicit ATK support.
Comment 3 Jan Schampera 2006-12-31 11:02:36 UTC
Hi Suns!

Can you tell me if that's the right way at all? I have no expirience with accessibility.

If you don't work with HEAD sourcecode, you can guess out of the patch what I do. I simply set explicit relations between some labels and their entries.

Though, the results that Orca reads out are - funny sometimes. As I never got in touch with that before, it can be that it's normal.


Comments?



J.
Comment 4 Damien Sandras 2007-01-02 13:18:21 UTC
Tim, any news?
Comment 5 padraig.obriain 2007-01-02 14:09:26 UTC
I think that we ought to be able to do this in a simpler way. I will try and come up with something.
Comment 6 padraig.obriain 2007-01-03 11:05:01 UTC
The labels should have mnemonics.

Then when gtk_label_set_mnemonic_widget is called to associate an edit field or combo box with a label you will get the label-for/labelled-by relations for free. There is code in gail which will generate the relations.
Comment 7 Tim Miao 2007-01-04 03:17:25 UTC
Thank you so much Padraig, I'm just back from holidays.
Comment 8 Jan Schampera 2008-09-11 03:51:58 UTC

*** This bug has been marked as a duplicate of 511462 ***
Comment 9 Eugen Dedu 2009-03-05 23:15:05 UTC
Could you modify the patch to take into account comment #6?  It could be included for ekiga 3.2 in ten days...
Comment 10 Eugen Dedu 2009-03-05 23:41:24 UTC
After reading some gnome for atk documentation, and as shown in comment #6, it seems to me the only thing to do is to add mnemonics to labels and call gtk_label_set_mnemonic_widget with the right edit box.  So the previous patch is too complex for that.  Could you confirm that?

Unfortunately, we are in string freeze, but this bug will be fixed in two weeks.
Comment 11 Eugen Dedu 2009-03-06 01:01:50 UTC
Created attachment 130165 [details] [review]
Fixes the account dialogs

The relation was already done (gtk_label_set_mnemonic_widget), it remained to set the mnemonics.

To be checked in after the string freeze.
Comment 12 Eugen Dedu 2009-04-05 21:53:50 UTC
Patch checked in, closing bug.