After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 367732 - Don't replace a channel object with a new version if it already exits.
Don't replace a channel object with a new version if it already exits.
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: Telepathy
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-30 16:18 UTC by Sjoerd Simons
Modified: 2006-10-31 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't insert if there is already a channel for the path (1.35 KB, patch)
2006-10-30 16:19 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2006-10-30 16:18:53 UTC 
Gossip telepathy's newchannel_cb always inserts a new text channel in the hash array even if an old one already exists. Normally this shouldn't matter, but the insertion triggers a synthesized Closed message which causes gossip to hash_table_remove the channel inside the hash_table_insert call..

Which causes some nasty problems..
Comment 1 Sjoerd Simons 2006-10-30 16:19:38 UTC 
Created attachment 75672 [details] [review]
Don't insert if there is already a channel for the path
Comment 2 Eitan Isaacson 2006-10-31 18:27:56 UTC 
It's brilliant (= it compiles)!

Thanks buddy.