GNOME Bugzilla – Bug 366694
PATCH: fix various (64 bit) bugs
Last modified: 2006-12-27 16:35:33 UTC
Steps to reproduce: Hi, First a short intro I'm a packager for the Fedora distribution and I've recently created a package of libgda-1.99.1 (not on the distro yet because not all apps work with it atm). Our current package is based on 1.9.100 and I had to apply some patches to fix a couple of crashes, I didn't submit those then because gda CVS was significantly different and they didn't apply to CVS. I've now ported these patches (where still nescesarry) to libga-1.99.1 and I'm submitting them now assuming they will apply to CVS now. I'll attach the patches to this bug once its created Stack trace: Other information:
Created attachment 75595 [details] [review] PATCH fixing various (64 bit) issues This patch fixes the following: -use of gda_data_model_hash_get_row in gda-bdb-recordset.c, the use here is wrong twice: 1) It doesn't pass the correct number of parameters (no prototype) 2) This function is declared static in an other file and thus not available Fix: 1) Pass correct number of parameters 2) Add prototype to header file 3) Make function not declared static -a 64 bit bug (cast of pointer to 32 bit integer type) in gda-odbc-provider.c -a missing header file leaving to implicit function decleration (which leads to potential 64 bit issues) in: bdb/libmain.c
Created attachment 75596 [details] [review] PATCH: gda-sharp.dll.config refers to wrong .so file
Thanks. I have commited the attached patch. I don't think the rest is still necessary, but please reopen this bug if I'm wrong.
Created attachment 78948 [details] [review] committed.patch This is what was committed.