After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 366523 - [directdraw] fix playback and vs8 fixes
[directdraw] fix playback and vs8 fixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.10.4
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-28 21:44 UTC by Sergey Scobich
Modified: 2006-11-01 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch (6.44 KB, patch)
2006-10-28 21:45 UTC, Sergey Scobich 		committed Details | Review

Description Sergey Scobich 2006-10-28 21:44:02 UTC 
Hi,

directdrawsink doesn't display the video for me, because ddraw fails on BltFast telling that clipper was not set on surface. Clipper is set too early on HWND=(NULL) because the code doesn't wait for window creation.

I implemented and attached the patch waiting for output window creation on max timeout 10 sec.

patch summary:
waiting for output window creation on max timeout 10 sec.
use HAVE_UNISTD_H
adding needed libs in vs8 project files.
Comment 1 Sergey Scobich 2006-10-28 21:45:11 UTC 
Created attachment 75583 [details] [review]
the patch
Comment 2 Tim-Philipp Müller 2006-11-01 10:18:51 UTC 
Thanks, committed:

 2006-11-01  Tim-Philipp Müller  <tim at centricular dot net>

	Patch by: Sergey Scobich  <sergey dot scobich at gmail com>

	* sys/directdraw/gstdirectdrawsink.c:
	(gst_directdrawsink_window_thread),
	(gst_directdrawsink_create_default_window):
	* sys/directdraw/gstdirectdrawsink.h:
	* sys/directsound/gstdirectsoundsink.c:
	  Wait until the window is created before using it; guard unistd.h
	  includes with HAVE_UNISTD_H. (#366523)

	* win32/vs8/libgstdirectdraw.vcproj:
	* win32/vs8/libgstdirectsound.vcproj:
	  Update project files.