GNOME Bugzilla – Bug 365388
gdk-pixbuf/Makefile.am: pixbufloader_pcx.def is not distributed
Last modified: 2006-10-28 23:37:46 UTC
Please describe the problem: pixbufloader_pcx.def is registered in CVS. But pixbufloader_pcx.def is not included in the archive. Steps to reproduce: 1. tar zxf gtk+-2.10.6.tar.gz 2. ls gtk+-2.10.6/gdk-pixbuf Actual results: pixbufloader_pcx.def is not found in gtk+-2.10.6.tar.gz. Expected results: Add pixbufloader_pcx.def at EXTRA_DIST in gdk-pixbuf/Makefile.am. Does this happen every time? every time Other information:
Hmm, the pixbufloader_*.def files aren't used at all in a mingw (gcc, auto*, libtool) build. (So the pixbuf loaders end up exporting all global symbols. That's not a problem on Win32 as such, and anyway the number of unintentionally exported symbols is very minimal, just a few functions related to the gobject types defined in the animation-capable loaders.) I assume the pixbufloader_*.def files would be used by the MSVC build then. But isn't that supposed to always use built-in pixbufloader modules, and I don't see the pixbufloader_*.def files mentioned in makefile.msc? Anyway, as all the pixbufloader_*.def files are identical, it's silly to have them as separate files, and in the tarball. I'll just remove them, and if necessary Hans can then set up a trivial rule in the MSVC makefile to produce a common .def file for pixbufloader DLLs in makefile.msc.
pixbufloader_*.def files removed in HEAD and gtk-2-10: 2006-10-29 Tor Lillqvist <tml@novell.com> * pixbufloader_*.def * Makefile.am (EXTRA_DIST): Remove pixbufloader_*.def, they are not used. (#365388) They were all identical, and exported just two symbols, so if somebody needs them for a MSVC build that doesn't use built-in modules it's trivial to hack makefile.msc to produce a common .def file for the loaders. The two symbols that need to be exported are fill_info and fill_vtable.