After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 364753 - Print Preview (zoom out) in Evolution has the effect of zoom in
Print Preview (zoom out) in Evolution has the effect of zoom in
Status: RESOLVED FIXED
Product: gnome-print
Classification: Deprecated
Component: print preview
2.6.x
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2006-10-24 17:10 UTC by Ghee Teo
Modified: 2006-11-10 11:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
a patch to fix the probelm (2.16 KB, patch)
2006-10-24 17:16 UTC, Ghee Teo
accepted-commit_now Details | Review

Description Ghee Teo 2006-10-24 17:10:53 UTC
Please describe the problem:
This happens when one has a dpi of 128. It is not happening if the user's display is below roughly 100.

Steps to Recreate:

-Launch Evolution
-Select any Mail/Task/Appointment
-File->Print Preview
-Print Preview window is diaplayed
-Click on Zoom Out button (with “-” sign)

Result: Zoom Out button increases the Preview size instead of decreasing it

Steps to reproduce:
1. 
2. 
3. 


Actual results:
Result: Zoom Out button increases the Preview size instead of decreasing it

Expected results:


Does this happen every time?
yes when the user's screen has resolution = 128 or more

Other information:
Comment 1 Ghee Teo 2006-10-24 17:16:45 UTC
Created attachment 75318 [details] [review]
a patch to fix the probelm

fix the problem and clean up some unused code within the function gnome_print_job_preview_zoom()
Comment 2 Kjartan Maraas 2006-10-30 12:39:49 UTC
Can't reproduce this here with evolution 2.9.x
Comment 3 Ghee Teo 2006-10-31 15:16:06 UTC
Kjartan, this problem only manifest itself when the dpi is > 102 dpi.

on a machine where I have,
$ xdpyinfo | grep resolu
  resolution:    90x90 dots per inch

This problem does not exist. but on 
$ xdpyinfo | grep resolu
  resolution:    129x127 dots per inch
That exists.

So you most probably need 1600X1050 or at least 1400x1050 resolution to see the problem.

what is your resolution when running evolution 2.9.x?
Comment 4 Ghee Teo 2006-11-03 15:10:25 UTC
I did you slight calculation, this bug is NOT reproduceable on evolution 2.8.x
if your screen resolution is

101x101 dots per inch or less

to be sure you need something like 105x105 or above to see the problem.
Comment 5 Jody Goldberg 2006-11-09 14:32:55 UTC
Comment on attachment 75318 [details] [review]
a patch to fix the probelm

doh!  Please commit.
Why would we make the zoom factor scale w.r.t. display size ?

scaling the zoom factor of 1/sqrt(2) by (n > 101)/72 inverts it.
Comment 6 Ghee Teo 2006-11-09 16:42:01 UTC
Hi Jody :)
I don't know the zoom factor is made with respect to dpi. My guess is that it is an attempt to make it resolution independent. However, it is not consistent in the zoom in factor though. With this patch, after, the zoom in and zoom out factor is consistent.

It might take me a while to commit this patch, as I have forgotten my passphase and it has been a while since I last committed changes to cvs.gnome.org. (since it changes  over to ssh) (embarassing) :/.
Comment 7 Kjartan Maraas 2006-11-10 09:11:53 UTC
Commited. Thanks.
Comment 8 Ghee Teo 2006-11-10 11:13:56 UTC
Kjartan, THANSK!