GNOME Bugzilla – Bug 364731
No support for negative scores
Last modified: 2007-07-09 03:12:55 UTC
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/evolution/+bug/67776 "Description of the problem: Attempting to create a search with a negative score results in an error dialog. Steps to reproduce: 1. Start evolution. 2. Click on a mail folder (e.g. On this Computer -> Inbox). 3. Go to Search -> Advanced Search... 4. In the Advanced Search dialog change the first Subject to Score and click the down arrow to turn the 0 to -1. 5. Click OK. Expected results: A search to be run. Actual results: Error dialog appears saying: "Error while Generating message list. Cannot parse search expression: Unknown identifier: -1: (and (match-all (and (not (system-flag "deleted")) (not (system-flag "junk")))) (and (or (match-all (= (cast-int (user-tag "score")) -1)) (match-all (header-contains "From" "")) ) ))" Version Information: evolution 2.8.1-0ubuntu4"
the help doc says: "Sets the message score to any whole number greater than 0." this is not a bug in my opinion.
the bug is that the widget allows to use -1
ah...
Created attachment 91090 [details] [review] proposed patch for evolution-data-server; I think the limits for score between -3..+3 is ok, so I did change in parser, where was allowed to start identifiers with '+' or '-' too, even those are unary operators. Other characters "<=>?" are strange to me too, but I kept them there.
OK, but I also get an error when trying to "Adjust Score" by a negative amount: Error while Filtering Selected Messages. Error parsing filter: Unknown identifier: -3: (begin (set-color "#e6db2000cd9f") (adjust-score -3) ) Certainly one must be able to reduce the score of a message, yes?
This patch fixes everything when I tested. Please commit to head.
committed to head.