Bug 364297 – crash in Keyring Manager: I unchecked the read per...

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 364297 - crash in Keyring Manager: I unchecked the read per...


Summary:	crash in Keyring Manager: I unchecked the read per...


Status:	RESOLVED FIXED

Product:	gnome-keyring-manager
Classification:	Deprecated
Component:	general
Version:	2.16.x
Hardware:	Other All

Importance:	High critical
Target Milestone:	---
Assigned To:	Keyring manager maintainers
QA Contact:	Keyring manager maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2006-10-22 22:38 UTC by simon80
Modified:	2006-12-18 01:00 UTC

See Also:
GNOME target:	---
GNOME version:	2.15/2.16

Attachments
Proposed patch (476 bytes, patch) 2006-12-05 09:40 UTC, padraig.obriain	none	Details \| Review

Description simon80 2006-10-22 22:38:43 UTC

Version: 2.16.0

What were you doing when the application crashed?
I unchecked the read permission from the file manager for accessing an sftp password, in the keyring manager, and that is when the keyring manager crashed.


Distribution: Gentoo Base System version 1.12.5
Gnome Release: 2.16.1 2006-10-14 (Gentoo)
BugBuddy Version: 2.16.0

Memory status: size: 28418048 vsize: 0 resident: 28418048 share: 0 rss: 11223040 rss_rlim: 0
CPU usage: start_time: 1161556419 rtime: 0 utime: 95 stime: 0 cutime:90 cstime: 0 timeout: 5 it_real_value: 0 frequency: 0

Backtrace was generated from '/usr/bin/gnome-keyring-manager'

Using host libthread_db library "/lib/libthread_db.so.1".
`system-supplied DSO at 0xffffe000' has disappeared; keeping its symbols.
[Thread debugging using libthread_db enabled]
[New Thread -1224345936 (LWP 1688)]
0xffffe410 in __kernel_vsyscall ()

+ Trace 77771

Thread 1 (Thread -1224345936 (LWP 1688))

#0 __kernel_vsyscall
#1 __waitpid_nocancel
from /lib/libpthread.so.0
#2 libgnomeui_segv_handle
at gnome-ui-init.c line 870
#3 <signal handler called>
#4 gnome_keyring_proto_add_acl
at gnome-keyring-proto.c line 909
#5 gnome_keyring_proto_encode_set_acl
at gnome-keyring-proto.c line 647
#6 gnome_keyring_item_set_acl
at gnome-keyring.c line 2093
#7 gkm_keyring_editor_set_acl
at gnome-keyring-manager-keyring-editor.c line 387
#8 on_acl_display_acl_changed
at gnome-keyring-manager-main-ui.c line 1023
#9 IA__g_cclosure_marshal_VOID__POINTER
at gmarshal.c line 601
#10 IA__g_closure_invoke
at gclosure.c line 490
#11 signal_emit_unlocked_R
at gsignal.c line 2440
#12 IA__g_signal_emit_valist
at gsignal.c line 2199
#13 IA__g_signal_emit
at gsignal.c line 2243
#14 checkbutton_toggled
at gnome-keyring-manager-acl-display.c line 345
#15 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#16 IA__g_closure_invoke
at gclosure.c line 490
#17 signal_emit_unlocked_R
at gsignal.c line 2440
#18 IA__g_signal_emit_valist
#19 IA__g_signal_emit
at gsignal.c line 2243
#20 IA__gtk_toggle_button_toggled
at gtktogglebutton.c line 311
#21 gtk_toggle_button_clicked
at gtktogglebutton.c line 444
#22 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#23 g_type_class_meta_marshal
at gclosure.c line 567
#24 IA__g_closure_invoke
at gclosure.c line 490
#25 signal_emit_unlocked_R
at gsignal.c line 2370
#26 IA__g_signal_emit_valist
#27 IA__g_signal_emit
at gsignal.c line 2243
#28 IA__gtk_button_clicked
at gtkbutton.c line 889
#29 gtk_toggle_button_released
at gtktogglebutton.c line 431
#30 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#31 g_type_class_meta_marshal
at gclosure.c line 567
#32 IA__g_closure_invoke
at gclosure.c line 490
#33 signal_emit_unlocked_R
at gsignal.c line 2370
#34 IA__g_signal_emit_valist
at gsignal.c line 2199
#35 IA__g_signal_emit
at gsignal.c line 2243
#36 IA__gtk_button_released
at gtkbutton.c line 881
#37 gtk_button_button_release
at gtkbutton.c line 1377
#38 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 84
#39 g_type_class_meta_marshal
at gclosure.c line 567
#40 IA__g_closure_invoke
at gclosure.c line 490
#41 signal_emit_unlocked_R
at gsignal.c line 2478
#42 IA__g_signal_emit_valist
at gsignal.c line 2209
#43 IA__g_signal_emit
at gsignal.c line 2243
#44 gtk_widget_event_internal
at gtkwidget.c line 3911
#45 IA__gtk_propagate_event
at gtkmain.c line 2188
#46 IA__gtk_main_do_event
at gtkmain.c line 1422
#47 gdk_event_dispatch
at gdkevents-x11.c line 2320
#48 IA__g_main_context_dispatch
at gmain.c line 2045
#49 g_main_context_iterate
at gmain.c line 2677
#50 IA__g_main_loop_run
at gmain.c line 2881
#51 IA__gtk_main
at gtkmain.c line 1001
#52 main
at gnome-keyring-manager.c line 157
#0 __kernel_vsyscall

Comment 1 padraig.obriain 2006-12-05 09:40:42 UTC

Created attachment 77717 [details] [review]
Proposed patch

I see this problem on Solaris. The proposed patch avoids adding NULL to list.

Comment 2 Kjartan Maraas 2006-12-06 01:14:07 UTC

Fer, is this ok?

Comment 3 Fernando Herrera 2006-12-18 01:00:35 UTC

Thanks a lot Padraig, committed to HEAD:
2006-12-18  Fernando Herrera  <fherrera@onirica.com>

        * src/gnome-keyring-manager-acl-display.c:
        (gkm_acl_display_get_acl): Don't add null elements to the
        acl list. Patch by Padraig Pbriain. Fix bug #364297