GNOME Bugzilla – Bug 362457
RFE to enable accessibility in unstable releases of GNOME
Last modified: 2007-01-12 12:02:34 UTC
In order to better support general testing in GNOME and to also provide more coverage of accessibility support in GNOME, it is kindly requested that accessibility support is enabled in unstable GNOME builds. See also the discussion at http://mail.gnome.org/archives/desktop-devel-list/2006-October/msg00135.html (patch coming soon)
Created attachment 74769 [details] [review] Patch to try to enable a11y in unstable releases of GNOME This patch is an attempt to enable a11y in unstable releases of GNOME, yet also allows people to explicitly turn it off if so desired. I've been unable to do an autogen of gnome-session under Ubuntu in order to test this, so I have little ides if it works or not. :-(
Aside from a couple minor formatting nits, this looks pretty reasonable to me. (Note though that I'm not a maintainer and can't approve patches.) A ChangeLog entry would be nice.
Created attachment 74770 [details] [review] Same patch with ChangeLog entry. Here's a revised patch with a ChangeLog entry. The revisions include adding a space between a * and the beginning of a comment line and replacing some tab character with spaces. The overall formatting may not be GNOME format guideline compliant, but instead attempts to follow the formatting style that's already in the module itself. I still don't know if this compiles or works, though, since I cannot get gnome-session to autogen on Ubuntu.
Should'nt you free a_t_value with gconf_value_free() after use it ?
(In reply to comment #4) > Should'nt you free a_t_value with gconf_value_free() after use it ? > Dunno - I guess since you say so, then it should. Thanks! :-)
Created attachment 74806 [details] [review] Patch to add freeing GConfValue Here's a revised patch to get us back those bytes that would be otherwise consumed for the user's session.
Created attachment 74863 [details] [review] Revised patch to use gconf_client_get_without_default Revised patch to use gconf_client_get_without_default. Thanks Alexander!
Willie: should we ignore this patch (see your latest mail on d-d-l)?
Yeah - let's reject the proposed patch and move this over to the libgnome component where the ultimate schema-based solution seems like the right thing to do.
See Fernando's e-mail for more info on the proposed solution: http://mail.gnome.org/archives/desktop-devel-list/2006-November/msg00001.html
Created attachment 76528 [details] [review] Patch from Fernando Herrera to do the magic
This was already applied and is out in 2.17.0. Does it not work as intended?
Ahh! Thanks for committing. :-) I just built/installed/tested it on Ubuntu Edgy 6.10 and it works like a charm. Thanks!