GNOME Bugzilla – Bug 361967
import function needs some UI improvements
Last modified: 2006-12-25 22:54:47 UTC
The import UI has some problems related to camera selection. 1. Currently, gthumb uses the FIRST auto-detected camera that is returned in a list from libgphoto. It ignores the others. 2. If there is an auto-detected camera, you can not change the camera selection to something else, if there is a better choice. (There is a patch for this in bug 348216, but I think we can do better). I think the main import dialog should have: a) A drop-down list of all auto-detected cameras, with a refresh button. b) A drop-down list of all possible cameras c) Some sort of use-auto-detect / use-manual-setting checkbox or radio button. d) The secondary camera-select dialog should be deleted, I think. I'll take a look at coding this, time permitting. - Mike
*** Bug 348216 has been marked as a duplicate of this bug. ***
Created attachment 75560 [details] [review] Improves camera auto-detection and model selection, v1 Paolo, Here is a patch that improves the camera model selection dialog. This patch does the following: 1) The camera model dialog now displays a list of ALL auto-detected cameras (for instance, if you have two cameras connected, or if libgphoto reports two possible configurations for one camera). This should resolve many camera compatibility issues. 2) It allows a different camera to be selected, even if an auto-detected camera is present. 3) It expands the import "Help" documentation. 4) The PNG description in the Help documentation has been updated as per bug 364767. Please review/commit! Thanks. - Mike
Applied to CVS HEAD.
I find this new import dialog too complicated. There are two groups of comboboxes for selecting a camera (one for auto-detected cameras and one for the full list), but they both serve the same purpose: selecting a camara. I would have kept the old dialog and added a checkbox "Show only auto-detected camaras" (or something similar). This checkbox would change the contents of the comboboxes to list only auto-detected cameras, or the full list. The "Refresh list" button of the new dialog is probably a better choice than the old "Auto Detect".
Yes, that might be better. Patches welcome... - Mike
Actually, I've thought about this some more, and I'm not sure I like the all-one-one approach, for two reasons: 1) The two sets of combo boxes map cleanly to two data structures. I know that isn't a good reason for UI design, but at least I can understand the code... 2) More importantly, I want to de-emphasize the manual selections and make it clear that they are a last resort. If your camera wasn't auto-detected, the odds that the manual selection will work are pretty low. I might check with the gphoto people to see what they think. Maybe the manual selection should be removed entirely if the odds of success are low... not sure. - Mike
Jef, Manuel has supplied an improved patch (at bug 380585) that should address your concerns (i.e., there is one set of combo boxes now). Please have a look. - Mike