GNOME Bugzilla – Bug 360537
Disable screensaver when playing video
Last modified: 2007-03-20 23:40:14 UTC
Stop the screen saver from kicking in when we are playing movies. I find myself having to move the mouse every couple of minutes or else my desktop gets locked. Other information: This should be in totem as well as in the totem plugins for browsers.
For the movie player, we only do that when in fullscreen. For the web browser plugin, I guess we should do the same when we implement the fullscreen mode. Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of 354181 ***
Bastien for the totem movie player. I am in full screen, and my desktop does get locked when playing... So this is not just a duplicate of 354181
Reopening.
Created attachment 74783 [details] [review] screen-saver-fix This patch fixes the problem with the screensaver in fullscreen mode
Created attachment 74784 [details] [review] totem-really-disable-ssaver.patch Simplify screensaver_is_running_dbus()
I have no idea why your patch would fix this bug, to be fair. I've updated it to simplify the code somewhat. Let me know whether it fixes it, and I'll push it to stable and HEAD, thanks.
(In reply to comment #6) > I have no idea why your patch would fix this bug, to be fair. I've updated it > to simplify the code somewhat. Let me know whether it fixes it, and I'll push > it to stable and HEAD, thanks. > Indeed, it seems weird... Execution in the enable/disable_scr_saver never went past the call to screensaver_is_running_dbus without the explicit comparisons. Preprocessor-oddities?
Something like that ;) Does the patch work?
(In reply to comment #8) > Something like that ;) > > Does the patch work? > Yep, it seems to work just fine!
Fixed in HEAD and gnome-2-16, thanks! 2006-10-16 Bastien Nocera <hadess@hadess.net> * src/totem-scrsaver.c: (screensaver_is_running_dbus), (totem_scrsaver_disable), (totem_scrsaver_enable): Modified patch from Niklas Mellegård <nmellegard@hotmail.com> to really disable the screensaver (weird stuff) (Closes: #360537)
What compiler and arch are you using?
(In reply to comment #10) > Fixed in HEAD and gnome-2-16, thanks! > > 2006-10-16 Bastien Nocera <hadess@hadess.net> > > * src/totem-scrsaver.c: (screensaver_is_running_dbus), > (totem_scrsaver_disable), (totem_scrsaver_enable): > Modified patch from Niklas Mellegård <nmellegard@hotmail.com> to > really disable the screensaver (weird stuff) (Closes: #360537) > Ermm... Now all of a sudden it's reverted back to not working again (still using the Totem build that did work). Sorry about this... William: I'm using * gcc (GCC) 4.1.2 20060928 (prerelease) (Ubuntu 4.1.1-13ubuntu5) * Linux LapLin 2.6.17-10-generic #2 SMP Fri Oct 13 18:45:35 UTC 2006 i686 GNU/Linux
If this still the case, I'll leave you in the good hands of Jon, because I have no idea how to debug that (most likely a configuration problem mind you).
Ok, please update gnome-screensaver to CVS HEAD from today. With that we can do: 1. Kill running gnome-screensaver 2. Run: gnome-screensaver --no-daemon --debug > /tmp/gs-debug.log 2>&1 3. Start totem 4. Play something 5. Run: sleep 5; dbus-send --session --dest=org.gnome.ScreenSaver --type=method_call --print-reply --reply-timeout=2000 /org/gnome/ScreenSaver org.gnome.ScreenSaver.GetInhibitors 6. Enter fullscreen in totem 7. Post the /tmp/gs-debug.log and the results of step 5 here
Created attachment 76034 [details] Log generated by gnome-screensaver Result of step 5: Error org.freedesktop.DBus.Error.UnknownMethod: Method "GetInhibitors" with signature "" on interface "org.gnome.ScreenSaver" doesn't exist
Ok, well you didn't update to CVS. I guess I should have also said to wait at step 6 until the screensaver activates while you are in fullscreen totem. I assume it did not because there is nothing in the log to indicate that it did. Is that correct?
Created attachment 76073 [details] gnome-ssaver log Ok, here's another try: * Totem freshly checked-out from CVS * gnome-ssaver setup to kick in after 1 min (and does) * The log should contain two ssaver start occasions * Result of step 5 is still the same as before
Thanks for the update. If we want to test using GetInhibitors we'll need gnome-screensaver from CVS HEAD not totem. However, I'm not sure it will help much here anyway. So, to recap. In the first debug log we saw that totem correctly inhibited the screensaver activation. In the second it did not and the screensaver activated. I'm assuming that gnome-screensaver was connected to the session bus correctly since we don't see any error messages in the log. So, the problem may be in Totem or in D-Bus. Can you: 1. Verify that Totem is being built with D-Bus support. The best way is to check the config.h file for #define WITH_DBUS 1. 2. Run totem from the command line and see if we get any warnings or errors. Maybe Bastien can suggest other ways to debug here. 3. Repeat the steps we outlined above. Thanks.
Indeed, totem wasn't built with D-Bus support! I added the #define and no screensaver kicked in, removed it and it did again.
The logging output from running autogen.sh says that dbus is indeed found and dbus-binding-tools as well. But still config.h does not get the define-statement... I made a recursive grep on all files checked out from the cvs, but nowhere (except in src/totem-scrsaver.c) does the string WITH_DBUS appear. Error in the configuration scripts (or have I totally misunderstood the whole thing)?
No information provided in the last 3 months. Please reopen your bug if it was closed in error.