After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359377 - patch to fix command-line quoting
patch to fix command-line quoting
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
git master
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
: 351751 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-03 19:46 UTC by Tom Tromey
Modified: 2007-01-06 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to quote command line arguments (1.08 KB, patch)
2006-10-03 19:47 UTC, Tom Tromey 		accepted-commit_now Details | Review

Description Tom Tromey 2006-10-03 19:46:46 UTC 
From what I can see, the new code in save.c to write out a desktop
entry does not properly quote its arguments.  I'll attach a patch
to change this.  Let me know what you think.
Comment 1 Tom Tromey 2006-10-03 19:47:55 UTC 
Created attachment 73967 [details] [review]
patch to quote command line arguments
Comment 2 Dan Winship 2006-10-11 04:16:11 UTC 
this is related to bug 351751 and should probably be fixed to fix that too
Comment 3 Tom Tromey 2006-10-23 04:19:18 UTC 
*** Bug 351751 has been marked as a duplicate of this bug. ***
Comment 4 Tom Tromey 2006-10-23 04:22:32 UTC 
I checked and this fixes bug #351751.
Comment 5 Vincent Untz 2006-11-14 18:23:10 UTC 
Just wondering out loud whether it'd be better or not to only quote the arguments when it's necessary...
Comment 6 Tom Tromey 2006-11-29 19:59:32 UTC 
I don't think it matters much, either in terms of performance
or in terms of memory use.  Most command lines are not very long.
Comment 7 Tom Tromey 2007-01-06 02:20:21 UTC 
Another reason not to check before quoting is that this
splits the knowledge of what must be quoted into two
different places.
Comment 8 Vincent Untz 2007-01-06 11:31:49 UTC 
Go ahead and commit this one too.
Thanks
Comment 9 Tom Tromey 2007-01-06 18:17:57 UTC 
Fix checked in.