After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359092 - Keyboard Shortcuts accept spacebar as a shortcut
Keyboard Shortcuts accept spacebar as a shortcut
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Keybinding
2.17.x
Other All
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 359094 402984 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-02 19:40 UTC by George
Modified: 2007-02-03 00:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
proposed fix (1.11 KB, patch)
2007-01-15 21:18 UTC, Jens Granseuer 		committed Details | Review

Description George 2006-10-02 19:40:52 UTC 
Please describe the problem:
Keyboard shortcuts accept the spacebar as a shortcut. That completely blocked my spacebar button, and I had to change the keyboard layout back and forth to the original layout to make the spacebar work again. I really dont think this is a permanent change tho, since I had that problem before too.

Steps to reproduce:
1. Go to the Keyboard Shortcuts window.
2. Chose any keyboard shortcut
3. Apply the "spacebar" for that shortcut



Actual results:
For me, it just blocked my spacebar button. I tried to remove that keybinding by using the "Backspace" on it, which should remove that, but it was still in effect. When I was pressing the spacebar button, the cursor was flickering (this means that it could understand that that button was using) but it didnt move the space. 

Expected results:


Does this happen every time?


Other information:
I suggest the complete rejection of the spacebar keybinding. Alt+spacebar or ctrl+spacebar should be acceptable, tho.
Comment 1 Elijah Newren 2006-10-02 19:50:35 UTC 
*** Bug 359094 has been marked as a duplicate of this bug. ***
Comment 2 Elijah Newren 2006-10-02 19:51:28 UTC 
The fact that you can't unbind the spacebar is already filed as bug 133815; I'll leave it open for "shouldn't allow binding simple keys like space, 0-9, a-z, etc."
Comment 3 Jens Granseuer 2007-01-15 21:18:51 UTC 
Created attachment 80339 [details] [review]
proposed fix

The attached patch (against 2.17.5) blacklists 0-9, space, and return in addition to a-z, A-Z which have already been rejected before. Arguably, there are still more keys we shouldn't accept, but this should be a minimum set we can all agree about (and hopefully enough to close this bug ;-)).
Comment 4 Thomas Wood 2007-01-15 22:43:54 UTC 
Perhaps we should reject any keys without a modifier, except multimedia keys?
Comment 5 Jens Granseuer 2007-01-16 08:56:24 UTC 
I think that would be a little too broad. I'd like to keep the F-keys, and I rarely if ever use my number pad and some of the keys in the center column. Plus, we'd probably also have to reject accels like <Shift>a which we don't catch right now.

In short, I'm not sure rejecting more but the most problematic and obviously unwanted accels is a good idea.
Comment 6 Jens Granseuer 2007-02-02 22:05:57 UTC 
Committed the patch. It's not perfect, but better than the situation before, and "good enough" until somebody else complains...
Comment 7 Thomas Wood 2007-02-03 00:42:23 UTC 
*** Bug 402984 has been marked as a duplicate of this bug. ***