GNOME Bugzilla – Bug 358638
network browsing doesn't work
Last modified: 2006-10-05 18:10:31 UTC
Network browsing from the libgnomeui filechooser plugin doesn't work. As stated by someone on desktop-devel-list, this is because g_keyfile is used to load a local file, which isn't possible when it's about a virtual gnomevfs URI like smblink-root.desktop.
Created attachment 73723 [details] [review] Patch to fix the problem Instead of resolving the uri to a local file and feeding to g_keyfile_load_from_file, just read the file using gnomevfs and feed it to g_keyfile_load_from_data.
Thanks for the patch, Jan :) This is the right solution in the short term. The long-term approach is to make those operations asynchronous. The patch is good to go for 2.16; please commit it to HEAD with a ChangeLog. For extra brownie points, please commit it to the "cancelation-changes" branch as well :) Thanks again!
I don't have commit access to CVS/SVN, so one of the gnome developers has to do it.
Commited. Thanks.
Created attachment 74044 [details] [review] patch adjusted for the branch Attaching the patch I commited on the branch for good measure. I had to apply it by hand since there were conflicts.
Btw, I think both calls to gnome_vfs_read_entire_file() should have &tmpsize and not tmpsize, I commited this slight fix to both branches since the patch as it stands causes warnings.
I think that also explains the corruption I had when passing tmpsize as length to g_keyfile_load_from_data. In that case the strlen would be useless and tmpsize can be used I guess.
Won't this hang the whole app while trying to retrieve the desktop file from the remote server? Also, why is this marked FIXED? Comment 2 says that the right thing is to make those operations asynchronous.
I don't know how gnomevfs creates these .desktop files, but if it creates them in-memory on the fly, it shouldn't matter much: as the .desktop file is in-memory at that moment, gnomevfs should be able to read it instantly and pass it to g_keyfile_load_from_data. AFAIK it's gnomevfs that creates these virtual files, allocates memory for it while scanning network shares, etc. After that, the files are read completely from memory, so the blocking part happens before the read process.
Created attachment 74071 [details] [review] Use tmpsize instead of strlen(tmp) (HEAD branch)
Created attachment 74073 [details] [review] same patch for cancelation-changes branch